-
Notifications
You must be signed in to change notification settings - Fork 7
do not require version keys in plate/well/labels #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Automated Review URLs |
dstansby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for the change. I just wanted to check if these changes to the next version of the spec are being collected anywhere in a changelog for implementers to follow along?
At the same time as this change to the spec text, shouldn't the schemas be updated too?
|
@dstansby thanks for the feedback. There is now a high-level changelog in the As for the schemas, I think the requirement for the |
|
Thanks! Of course, I forgot that the schema/text were out of sync before this. |
Fixes ome/ngff#309
Fixes ome/ngff#322
Mirrors ome/ngff#324
This PR removes the requirement for having a
versionkey under theplate/well/labelsobjects. In a previous version, theversionkey was moved up under theomekey. I clarified the statement under theomesection a little so it's clearer that theversionkey MUST be provided there.