Skip to content

Conversation

@jo-mueller
Copy link
Contributor

@jo-mueller jo-mueller commented Feb 2, 2026

Fixes ome/ngff#309
Fixes ome/ngff#322
Mirrors ome/ngff#324

This PR removes the requirement for having a version key under the plate/well/labels objects. In a previous version, the version key was moved up under the ome key. I clarified the statement under the ome section a little so it's clearer that the version key MUST be provided there.

@jo-mueller jo-mueller added the documentation Improvements or additions to documentation label Feb 2, 2026
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Automated Review URLs

Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the change. I just wanted to check if these changes to the next version of the spec are being collected anywhere in a changelog for implementers to follow along?

At the same time as this change to the spec text, shouldn't the schemas be updated too?

@jo-mueller
Copy link
Contributor Author

@dstansby thanks for the feedback. There is now a high-level changelog in the version_history.md document, I've also added this change there.

As for the schemas, I think the requirement for the version key in the schemas had already been dropped in 0.5 and making the appropriate change in the spec text had just been forgotten. So this is more of a cleanup than a change to bring schemas and spec back in sync.

@dstansby
Copy link
Contributor

dstansby commented Feb 2, 2026

Thanks! Of course, I forgot that the schema/text were out of sync before this.

@jo-mueller jo-mueller merged commit f7da49b into ome:main Feb 5, 2026
4 checks passed
@jo-mueller jo-mueller deleted the un-require-version-keys branch February 5, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plate JSON examples in the specification are invalid Are previous version keys allowed in v0.5?

5 participants