fix(forms): use Flags().Changed() for update, reject --file + --title conflict#131
Merged
fix(forms): use Flags().Changed() for update, reject --file + --title conflict#131
Conversation
… conflict - Use cmd.Flags().Changed() instead of empty-string checks to detect whether --title and --description were provided. This allows setting empty values to clear fields (e.g., --description ""). - Add explicit conflict guard: --file cannot be combined with --title or --description. Previously --file silently took precedence. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge review fixes for PR #124 (forms parity). Addresses issues found by Codex:
cmd.Flags().Changed()instead of empty-string checks to detect whether--titleand--descriptionwere provided. This allows clearing fields by passing empty values (e.g.,--description "").--fileis combined with--titleor--description. Previously--filesilently took precedence and the inline flags were ignored.Test plan
go vet ./...cleango test ./...all passgws forms update <id> --title "New Title" --description ""clears description🤖 Generated with Claude Code