Skip to content

fix(forms): use Flags().Changed() for update, reject --file + --title conflict #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omriariav merged 1 commit into from
Feb 19, 2026
Merged

fix(forms): use Flags().Changed() for update, reject --file + --title conflict #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions cmd/forms.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,9 +453,17 @@ func runFormsUpdate(cmd *cobra.Command, args []string) error {
title, _ := cmd.Flags().GetString("title")
description, _ := cmd.Flags().GetString("description")

hasFile := cmd.Flags().Changed("file")
hasTitle := cmd.Flags().Changed("title")
hasDescription := cmd.Flags().Changed("description")

if hasFile && (hasTitle || hasDescription) {
return p.PrintError(fmt.Errorf("--file cannot be combined with --title or --description"))
}

var batchReq forms.BatchUpdateFormRequest

if filePath != "" {
if hasFile {
// Read batch update request from file
data, err := os.ReadFile(filePath)
if err != nil {
Expand All @@ -465,11 +473,11 @@ func runFormsUpdate(cmd *cobra.Command, args []string) error {
if err := json.Unmarshal(data, &batchReq); err != nil {
return p.PrintError(fmt.Errorf("failed to parse JSON: %w", err))
}
} else if title != "" || description != "" {
} else if hasTitle || hasDescription {
// Build simple update request for title/description
var requests []*forms.Request

if title != "" {
if hasTitle {
requests = append(requests, &forms.Request{
UpdateFormInfo: &forms.UpdateFormInfoRequest{
Info: &forms.Info{
Expand All @@ -480,7 +488,7 @@ func runFormsUpdate(cmd *cobra.Command, args []string) error {
})
}

if description != "" {
if hasDescription {
requests = append(requests, &forms.Request{
UpdateFormInfo: &forms.UpdateFormInfoRequest{
Info: &forms.Info{
Expand Down
Loading