Add citizenlab url management with porcelain #1057
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test helpers from oonimeasurements: create_jwt, create_session_token, client_with_admin_role, client_with_user_role FIXME: validation of session still fails, monkeypatch auth didn't seem to work
this is to preserve the keys in json response for backwards compatibility
update handler accepts either being None to differentiate behavior
api change in filelock 3.11.0 means that FileLock is not shared between threads by default
raises exception if lock was not held
this fixes hanging git processes left by clone_from
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same service as #1050 but with gitpython replaced with https://dulwich.io/ (https://github.com/jelmer/dulwicha) which is a python implementation of git. The reason for the switch is that the gitpython project spawns a git process but leaves hanging zombie processes that consume file descriptors
gitpython-developers/GitPython#1333
gitpython-developers/GitPython#1215
It seems that using the _clone() method (e.g. clone_from()) is the culprit because swapping out clone_from with dulwich.porcelain.clone solved the zombie process problem, so I just replaced the rest of the library and this eliminates git and gitpython as dependencies.