feat: remove border radius & extra content#4083
feat: remove border radius & extra content#4083filippovskii09 wants to merge 5 commits intoopenedx:release-23.xfrom
Conversation
|
Thanks for the pull request, @filippovskii09! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4083 +/- ##
================================================
- Coverage 94.39% 94.38% -0.01%
================================================
Files 242 242
Lines 4296 4294 -2
Branches 1020 981 -39
================================================
- Hits 4055 4053 -2
Misses 237 237
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PKulkoRaccoonGang
left a comment
There was a problem hiding this comment.
I checked, it seems to look much better now. Thanks for this fix!
src/SearchField/index.jsx
Outdated
| export const SEARCH_FIELD_SCREEN_READER_TEXT_SUBMIT_BUTTON = 'submit search'; | ||
| export const SEARCH_FIELD_SCREEN_READER_TEXT_CLEAR_BUTTON = 'clear search'; | ||
| export const SEARCH_FIELD_BUTTON_TEXT = 'search'; | ||
| export const SEARCH_FIELD_BUTTON_TEXT = 'Search'; |
There was a problem hiding this comment.
We should probably just remove this completely. We already have a default for buttonText in SearchField.SubmitButton
paragon/src/SearchField/SearchFieldSubmitButton.jsx
Lines 70 to 74 in d2dc235
So it'd be nice to not have this defined in 2 places.
There was a problem hiding this comment.
The SEARCH_FIELD_BUTTON_TEXT variable has been removed
…o filippovskii/fix/styles-for-search-button
Description
In this PR was added style fixes for Search Submit Button
Issues
#2674
#4023
Before:

After:
