Skip to content

Conversation

@sebrandon1
Copy link
Contributor

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against main.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example of a successful run:

$ make test-kustomize 
./hack/test-kustomize.sh
Checking all kustomization.yaml files can build successfully...

  ./telco-core/configuration: SKIPPED (requires external plugins)
  ./telco-hub/configuration/example-overlays-config/acm: OK
  ./telco-hub/configuration/example-overlays-config/gitops: OK
  ./telco-hub/configuration/example-overlays-config/logging: OK
  ./telco-hub/configuration/example-overlays-config/lso: OK
  ./telco-hub/configuration/example-overlays-config/odf: OK
  ./telco-hub/configuration/example-overlays-config/registry: OK
  ./telco-hub/configuration: OK
  ./telco-hub/configuration/reference-crs: OK
  ./telco-hub/configuration/reference-crs/optional/logging: OK
  ./telco-hub/configuration/reference-crs/optional/lso: OK
  ./telco-hub/configuration/reference-crs/optional/odf-internal: OK
  ./telco-hub/configuration/reference-crs/required/acm: OK
  ./telco-hub/configuration/reference-crs/required/gitops: OK
  ./telco-hub/configuration/reference-crs/required/gitops/ztp-installation: OK
  ./telco-hub/configuration/reference-crs/required/registry: OK
  ./telco-hub/configuration/reference-crs/required/talm: OK
  ./telco-ran/configuration/argocd/deployment: OK
  ./telco-ran/configuration/argocd/example/acmpolicygenerator: SKIPPED (requires external plugins)
  ./telco-ran/configuration/argocd/example/clusterinstance: SKIPPED (requires external plugins)
  ./telco-ran/configuration/argocd/example/image-based-upgrades: SKIPPED (requires external plugins)
  ./telco-ran/configuration/argocd/example/policygentemplates: SKIPPED (requires external plugins)
  ./telco-ran/configuration/argocd/example/siteconfig: SKIPPED (requires external plugins)

Summary: Checked 17 kustomization.yaml files, skipped 6 (require external plugins)
All kustomization files validated successfully!

@openshift-ci openshift-ci bot requested review from SchSeba and sabbir-47 October 29, 2025 19:45
@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebrandon1
Copy link
Contributor Author

@lack
Copy link
Member

lack commented Oct 30, 2025

/retest

@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch 2 times, most recently from 40a7d24 to b434060 Compare December 8, 2025 20:18
@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch from b434060 to 631d666 Compare December 18, 2025 20:38
@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch from 631d666 to af4bf37 Compare January 13, 2026 14:53
@sebrandon1 sebrandon1 changed the title Add kustomize validation check CNFCERT-1258: Add kustomize validation check Jan 16, 2026
@openshift-ci-robot
Copy link
Collaborator

@sebrandon1: This pull request references CNFCERT-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against main.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example of a successful run:

$ make test-kustomize 
./hack/test-kustomize.sh
Checking all kustomization.yaml files can build successfully...

 ./telco-core/configuration: SKIPPED (requires external plugins)
 ./telco-hub/configuration/example-overlays-config/acm: OK
 ./telco-hub/configuration/example-overlays-config/gitops: OK
 ./telco-hub/configuration/example-overlays-config/logging: OK
 ./telco-hub/configuration/example-overlays-config/lso: OK
 ./telco-hub/configuration/example-overlays-config/odf: OK
 ./telco-hub/configuration/example-overlays-config/registry: OK
 ./telco-hub/configuration: OK
 ./telco-hub/configuration/reference-crs: OK
 ./telco-hub/configuration/reference-crs/optional/logging: OK
 ./telco-hub/configuration/reference-crs/optional/lso: OK
 ./telco-hub/configuration/reference-crs/optional/odf-internal: OK
 ./telco-hub/configuration/reference-crs/required/acm: OK
 ./telco-hub/configuration/reference-crs/required/gitops: OK
 ./telco-hub/configuration/reference-crs/required/gitops/ztp-installation: OK
 ./telco-hub/configuration/reference-crs/required/registry: OK
 ./telco-hub/configuration/reference-crs/required/talm: OK
 ./telco-ran/configuration/argocd/deployment: OK
 ./telco-ran/configuration/argocd/example/acmpolicygenerator: SKIPPED (requires external plugins)
 ./telco-ran/configuration/argocd/example/clusterinstance: SKIPPED (requires external plugins)
 ./telco-ran/configuration/argocd/example/image-based-upgrades: SKIPPED (requires external plugins)
 ./telco-ran/configuration/argocd/example/policygentemplates: SKIPPED (requires external plugins)
 ./telco-ran/configuration/argocd/example/siteconfig: SKIPPED (requires external plugins)

Summary: Checked 17 kustomization.yaml files, skipped 6 (require external plugins)
All kustomization files validated successfully!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants