-
Notifications
You must be signed in to change notification settings - Fork 1.5k
OCPBUGS-55407: set DNS zone for Azure Stack Hub private clusters #10233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Azure Stack Hub only supports a single DNS zone type (not separate public/private zones). When installing a cluster on Azure Stack Hub, the DNS manifest must specify the PrivateZone field pointing to the base domain zone so that the ingress operator can create *.apps DNS records. Previously, the DNS manifest generation set PrivateZone only for non-ASH clusters, leaving Azure Stack Hub clusters without zone configuration. This caused the ingress operator to fail with DNS resolution errors. Fixes https://issues.redhat.com/browse/OCPBUGS-55407
|
@jinyunma: This pull request references Jira Issue OCPBUGS-55407, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira refresh |
|
@jinyunma: This pull request references Jira Issue OCPBUGS-55407, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Tested locally, private cluster installation on azure stack hub succeeded. |
|
/test e2e-azurestack |
1 similar comment
|
/test e2e-azurestack |
|
@jinyunma: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Installation for job e2e-azurestack in this PR and pre-merge tested job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-azure-stack-ipi-private-f28 succeeded. |
|
/lgtm The ci/prow/e2e-azurestack job has been perma failing. Are there other errors in there that we need to open bugs for? |
Most failed cases are related with storage, checked with storage QE, those cases are not supported on Azure Stack Hub, myabe we need to filter to exclude them. |
|
/verified by jima |
|
@jinyunma: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Azure Stack Hub only supports a single DNS zone type (not separate public/private zones). When installing a cluster on Azure Stack Hub, the DNS manifest must specify the PrivateZone field pointing to the base domain zone so that the ingress operator can create *.apps DNS records.
Previously, the DNS manifest generation set PrivateZone only for non-ASH clusters, leaving Azure Stack Hub clusters without zone configuration. This caused the ingress operator to fail with DNS resolution errors.