Skip to content

Conversation

@jinyunma
Copy link
Contributor

Azure Stack Hub only supports a single DNS zone type (not separate public/private zones). When installing a cluster on Azure Stack Hub, the DNS manifest must specify the PrivateZone field pointing to the base domain zone so that the ingress operator can create *.apps DNS records.

Previously, the DNS manifest generation set PrivateZone only for non-ASH clusters, leaving Azure Stack Hub clusters without zone configuration. This caused the ingress operator to fail with DNS resolution errors.

Azure Stack Hub only supports a single DNS zone type (not separate
public/private zones). When installing a cluster on Azure Stack Hub,
the DNS manifest must specify the PrivateZone field pointing to the base
domain zone so that the ingress operator can create *.apps DNS records.

Previously, the DNS manifest generation set PrivateZone only for non-ASH
clusters, leaving Azure Stack Hub clusters without zone configuration.
This caused the ingress operator to fail with DNS resolution errors.

Fixes https://issues.redhat.com/browse/OCPBUGS-55407
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This pull request references Jira Issue OCPBUGS-55407, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Azure Stack Hub only supports a single DNS zone type (not separate public/private zones). When installing a cluster on Azure Stack Hub, the DNS manifest must specify the PrivateZone field pointing to the base domain zone so that the ingress operator can create *.apps DNS records.

Previously, the DNS manifest generation set PrivateZone only for non-ASH clusters, leaving Azure Stack Hub clusters without zone configuration. This caused the ingress operator to fail with DNS resolution errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tthvo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from andfasano and rna-afk January 19, 2026 06:27
@jinyunma jinyunma changed the title [WIP] OCPBUGS-55407: set DNS zone for Azure Stack Hub private clusters OCPBUGS-55407: set DNS zone for Azure Stack Hub private clusters Jan 19, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2026
@jinyunma
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This pull request references Jira Issue OCPBUGS-55407, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@jinyunma: This pull request references Jira Issue OCPBUGS-55407, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jinyunma
Copy link
Contributor Author

Tested locally, private cluster installation on azure stack hub succeeded.

$ oc get cm -n kube-system cluster-config-v1 -oyaml
apiVersion: v1
data:
  install-config: |
......
   publish: Internal
    pullSecret: ""
......

$ oc get dns cluster -oyaml
apiVersion: config.openshift.io/v1
kind: DNS
metadata:
  creationTimestamp: "2026-01-19T10:45:42Z"
  generation: 1
  name: cluster
  resourceVersion: "357"
  uid: c1c04a21-7d86-48c8-82e5-25062bfa1b4b
spec:
  baseDomain: jima-ash19b.installer.redhat.wwtatc.com
  platform:
    type: ""
  privateZone:
    id: /subscriptions/de7e09c3-b59a-4c7d-9c77-439c11b92879/resourceGroups/openshiftInstallerRG/providers/Microsoft.Network/dnszones/installer.redhat.wwtatc.com
status: {}

@jinyunma
Copy link
Contributor Author

/test e2e-azurestack

1 similar comment
@jinyunma
Copy link
Contributor Author

/test e2e-azurestack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@jinyunma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack 5d8a86a link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jinyunma
Copy link
Contributor Author

Installation for job e2e-azurestack in this PR and pre-merge tested job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-azure-stack-ipi-private-f28 succeeded.

/cc @patrickdillon @sadasu

@sadasu
Copy link
Contributor

sadasu commented Jan 26, 2026

/lgtm

The ci/prow/e2e-azurestack job has been perma failing. Are there other errors in there that we need to open bugs for?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2026
@jinyunma
Copy link
Contributor Author

jinyunma commented Jan 27, 2026

Are there other errors in there that we need to open bugs for?

Most failed cases are related with storage, checked with storage QE, those cases are not supported on Azure Stack Hub, myabe we need to filter to exclude them.

@jinyunma
Copy link
Contributor Author

/verified by jima

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 27, 2026
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This PR has been marked as verified by jima.

Details

In response to this:

/verified by jima

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants