Skip to content

OCPBUGS-55407: set DNS zone for Azure Stack Hub private clusters #10233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinyunma wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

OCPBUGS-55407: set DNS zone for Azure Stack Hub private clusters #10233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/asset/manifests/dns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,15 @@ func (d *DNS) Generate(ctx context.Context, dependencies asset.Parents) error {
ID: dnsConfig.GetDNSZoneID(installConfig.Config.Azure.BaseDomainResourceGroupName, installConfig.Config.BaseDomain),
}
}
if installConfig.Azure.CloudName != azuretypes.StackCloud {

// Azure Stack Hub only supports "DNS zones"--there is not a private/public zone distinction.
// Set PrivateZone to the base domain zone for ASH, or cluster private zone for regular Azure.
if installConfig.Azure.CloudName == azuretypes.StackCloud {
// Azure Stack Hub uses the base domain zone for all DNS records (api, api-int, *.apps)
config.Spec.PrivateZone = &configv1.DNSZone{
ID: dnsConfig.GetDNSZoneID(installConfig.Config.Azure.BaseDomainResourceGroupName, installConfig.Config.BaseDomain),
}
} else {
config.Spec.PrivateZone = &configv1.DNSZone{
ID: dnsConfig.GetPrivateDNSZoneID(installConfig.Config.Azure.ClusterResourceGroupName(clusterID.InfraID), installConfig.Config.ClusterDomain()),
}
Expand Down