Skip to content

Conversation

@petr-muller
Copy link
Member

The periodics variant configs do not need to contain images stanza (unless something in the jobs themselves needs the built image). The periodics are configured to install/update to releases.latest unmodified, but the jobs will still build the image from whatever the corresponding branch HEAD at the trigger time. This takes time, a bit of compute and also causes a redundant -images job to exist. None of this is necessary.

@petr-muller
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@petr-muller
Copy link
Member Author

#72630 should go first (and then this needs to be updated for 4.22 stuff)

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2025
@flavianmissi
Copy link
Member

TIL. Thanks for taking care it, Petr.

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2025
The `periodics` variant configs do not need to contain `images` stanza (unless something in the jobs themselves needs the built image). The periodics are configured to install/update to `releases.latest` unmodified, but the jobs will still build the image from whatever the corresponding branch HEAD at the trigger time. This takes time, a bit of compute and also causes a redundant -images job to exist. None of this is necessary.
@petr-muller petr-muller force-pushed the image-registry-periodic-do-not-build-images branch from 4d93aa6 to 5ab1ea6 Compare December 18, 2025 17:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@petr-muller: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-image-registry-release-4.22-periodics-e2e-gcp-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-aws-sno-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-metal-ovn-ipv6-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.22-periodics-e2e-azure-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.22-periodics-e2e-aws-sno-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.22-periodics-e2e-metal-ovn-ipv6-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.22-periodics-e2e-vsphere-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-gcp-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-azure-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-vsphere-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-aws-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-metal-ovn-dualstack-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-metal-ovn-ipv4-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.22-periodics-e2e-aws-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.22-periodics-e2e-metal-ovn-dualstack-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-image-registry-release-4.22-periodics-e2e-metal-ovn-ipv4-image-stream-import-mode-techpreview N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@petr-muller
Copy link
Member Author

/pj-rehearse
/hold cancel

@openshift-ci-robot
Copy link
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@petr-muller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-vsphere-image-stream-import-mode-techpreview 5ab1ea6 link unknown /pj-rehearse periodic-ci-openshift-image-registry-release-4.21-periodics-e2e-vsphere-image-stream-import-mode-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants