-
Notifications
You must be signed in to change notification settings - Fork 2k
images-registry: remove unused built image from variant configs #72741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
images-registry: remove unused built image from variant configs #72741
Conversation
|
/pj-rehearse |
|
@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
#72630 should go first (and then this needs to be updated for 4.22 stuff) /hold |
|
TIL. Thanks for taking care it, Petr. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavianmissi, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The `periodics` variant configs do not need to contain `images` stanza (unless something in the jobs themselves needs the built image). The periodics are configured to install/update to `releases.latest` unmodified, but the jobs will still build the image from whatever the corresponding branch HEAD at the trigger time. This takes time, a bit of compute and also causes a redundant -images job to exist. None of this is necessary.
4d93aa6 to
5ab1ea6
Compare
|
New changes are detected. LGTM label has been removed. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@petr-muller: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The
periodicsvariant configs do not need to containimagesstanza (unless something in the jobs themselves needs the built image). The periodics are configured to install/update toreleases.latestunmodified, but the jobs will still build the image from whatever the corresponding branch HEAD at the trigger time. This takes time, a bit of compute and also causes a redundant -images job to exist. None of this is necessary.