TRT-2452: Create missing 4.22 periodic variants #72630
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@neisw: This pull request references TRT-2452 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @petr-muller |
|
xref: #71837 to figure out what got missed in pre-branching |
openshift-merge-robot
added
the
needs-rebase
|
I have started looking into this today, will finish tomorrow - let's refresh this PR sometimes closer to EU EoD and I'll flag it to merge? |
# Conflicts: # ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22__periodics.yaml # ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22-periodics.yaml
neisw
force-pushed
the
trt-2452-post-4.22-periodics
branch
from
2943d0a to
3277db9
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Looks like MCO add their jobs and caused conflicts. We can refresh again as needed. |
|
[REHEARSALNOTIFIER]
A total of 191 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
petr-muller
left a comment
petr-muller
left a comment
There was a problem hiding this comment.
I do not think there's a good reason to not merge this before the break, so lgtm+hold and unhold as needed
/hold
Some interesting stuff I noticed:
- Some of the configs waste resources by specifying to build some images, which causes some waste at runtime (building images that are not used) and at config time (creating presubmits and postsubmits without value)
- It is interesting that some periodics are configured to test nightlies and some to test ci releases
- The inclusion of cluster-node-tuning-operator periodics was a bit surprising, because the job is not configured in a way that causes the periodics to carry the
job-releaselabel, whcih I thought is the identifier for "jobs that TRT cares about".
I have created some PRs as I went to address the wasteful config:
These do not need to go first, I'll just need to followup and do the changes in the newly merged 4.22 configs as well.
| images: | ||
| - dockerfile_path: Dockerfile.rhel7 | ||
| inputs: | ||
| ocp_4.22_base-rhel9: | ||
| as: | ||
| - registry.ci.openshift.org/ocp/4.22:base-rhel9 | ||
| ocp_builder_rhel-9-golang-1.24-openshift-4.22: | ||
| as: | ||
| - registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 | ||
| to: cluster-authentication-operator |
There was a problem hiding this comment.
I think images should not be here, the built image is not used and it will just cause an image to built (time+resources), and cause a reduntant presubmit to exist
There was a problem hiding this comment.
In general this approach just takes what exists for 4.21 and bumps it up to 4.22 without any analysis on the structure. It will be interesting to see how we can improve upon this and flag wasteful / unnecessary config in the future.
| promotion: | ||
| to: | ||
| - disabled: true | ||
| name: "4.22" | ||
| namespace: ocp |
There was a problem hiding this comment.
This should not be here, this will cause a reduntant postsubmit to exist.
| integration: | ||
| include_built_images: true | ||
| name: "4.22" | ||
| namespace: ocp |
There was a problem hiding this comment.
I wonder if we have any expectations about what should the periodics test? The aws-karpenter-provide-aws tests the latest ci release, and this config builds a new ephemeral release from the integration imagestream (the ci release upstream).
Also include_built_images is useless here, the config builds no images.
There was a problem hiding this comment.
Also, interestingly -- these periodics will not have the job-release: "4.22" label because it is derivative of the release.latest shape, and this config does not match.
I thought TRT only cares about the jobs with this label.
| candidate: | ||
| product: ocp | ||
| stream: nightly | ||
| version: "4.22" |
There was a problem hiding this comment.
haha and this one tests nightlies
| images: | ||
| - dockerfile_path: Dockerfile.ocp | ||
| inputs: | ||
| ocp_4.22_base-rhel9: | ||
| as: | ||
| - registry.ci.openshift.org/ocp/4.22:base-rhel9 | ||
| ocp_builder_rhel-9-golang-1.24-openshift-4.22: | ||
| as: | ||
| - registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 | ||
| to: docker-registry | ||
| promotion: | ||
| to: | ||
| - disabled: true | ||
| name: "4.22" | ||
| namespace: ocp |
| images: | ||
| - dockerfile_path: Dockerfile | ||
| inputs: | ||
| ocp_4.22_base-rhel9: | ||
| as: | ||
| - registry.ci.openshift.org/ocp/4.22:base-rhel9 | ||
| ocp_builder_rhel-9-golang-1.24-openshift-4.22: | ||
| as: | ||
| - registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 | ||
| to: insights-operator |
| requests: | ||
| cpu: 100m | ||
| memory: 200Mi | ||
| tests: |
| requests: | ||
| cpu: 100m | ||
| memory: 200Mi | ||
| tests: |
There was a problem hiding this comment.
I believe they are working hard on migrating QE jobs over
openshift-ci
bot
added
the
do-not-merge/hold
|
@neisw: This pull request references TRT-2452 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/pj-rehearse ack |
|
@neisw: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/approve |
openshift-ci
bot
added
the
approved
|
@neisw: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
Post 4.21 branching to migrate periodic variant configurations
Generated with Claude:
/migrate-variant-periodics --skip-existing 4.21 4.22This is an alternative to DPTP-4435 while we wait to see what is possible there.