Skip to content

Conversation

@petr-muller
Copy link
Member

The periodics variant configs do not need to contain images stanza (unless something in the jobs themselves needs the built image). The periodics are configured to install/update to releases.latest unmodified, but the jobs will still build the image from whatever the corresponding branch HEAD at the trigger time. This takes time, a bit of compute and also causes a redundant -images job to exist. None of this is necessary.

@petr-muller
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@petr-muller
Copy link
Member Author

#72630 should go first (and then this needs to be updated for 4.22 stuff)

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2025
@petr-muller petr-muller force-pushed the insights-periodic-do-not-build-images branch 2 times, most recently from 0d67276 to 24a157f Compare December 18, 2025 17:14
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign opokornyy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The `periodics` variant configs do not need to contain `images` stanza (unless something in the jobs themselves needs the built image). The periodics are configured to install/update to `releases.latest` unmodified, but the jobs will still build the image from whatever the corresponding branch HEAD at the trigger time. This takes time, a bit of compute and also causes a redundant -images job to exist. None of this is necessary.
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 18, 2025
@petr-muller petr-muller force-pushed the insights-periodic-do-not-build-images branch from 24a157f to 69a3cd5 Compare December 18, 2025 17:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 18, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@petr-muller: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-insights-operator-release-4.21-periodics-metal-insights-runtime-extractor-tests-ipv4 N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.20-periodics-e2e-azure-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-aws-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-hosted-hypershift-insights-operator-e2e-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-gcp-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-insights-operator-e2e-tests-slow-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-azure-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.22-periodics-insights-operator-e2e-tests-slow-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.22-periodics-insights-operator-e2e-tests-periodic N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.22-periodics-e2e-aws-single-node-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.22-periodics-e2e-metal-dualstack-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.20-periodics-azure-insights-runtime-extractor-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-insights-operator-e2e-tests-periodic N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.22-periodics-e2e-vsphere-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-vsphere-insights-runtime-extractor-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-aws-insights-runtime-extractor-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.20-periodics-e2e-metal-techpreview-ipv4 N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.20-periodics-aws-insights-runtime-extractor-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.22-periodics-e2e-metal-ipv6-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-vsphere-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-metal-ipv6-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-metal-techpreview-ipv4 N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.22-periodics-e2e-metal-techpreview-ipv4 N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.20-periodics-e2e-gcp-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-insights-operator-release-4.22-periodics-e2e-gcp-techpreview N/A periodic Ci-operator config changed

A total of 50 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@petr-muller
Copy link
Member Author

/pj-rehearse
/hold cancel

@openshift-ci-robot
Copy link
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2025
@petr-muller
Copy link
Member Author

This is the difference:

Job before the change: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-insights-operator-release-4.20-periodics-e2e-azure-techpreview/2001442600287997952

INFO[2025-12-18T00:01:42Z] ci-operator version v20251215-f0f4b3b2a      
...
INFO[2025-12-18T00:01:54Z] Building src                                 
INFO[2025-12-18T00:01:54Z] Created build "src-amd64"                    
INFO[2025-12-18T00:08:17Z] Build src-amd64 succeeded after 2m0s         
INFO[2025-12-18T00:08:17Z] Retrieving digests of member images          
INFO[2025-12-18T00:08:19Z] Image ci-op-9hchsbtn/pipeline:src created     digest=sha256:eb887d50ab86b103ee8f5868574a42cea00ca650760fc281be354162bdf170d4 for-build=src
INFO[2025-12-18T00:08:19Z] Building insights-operator                   
INFO[2025-12-18T00:08:19Z] Created build "insights-operator-amd64"      
INFO[2025-12-18T00:10:33Z] Importing release 4.20.0-0.nightly-2025-12-17-043535 created at 2025-12-17 04:37:14 +0000 UTC with 192 images to tag release:latest ... 
INFO[2025-12-18T00:11:57Z] Build insights-operator-amd64 succeeded after 3m38s 
INFO[2025-12-18T00:11:57Z] Retrieving digests of member images          
INFO[2025-12-18T00:11:58Z] Image ci-op-9hchsbtn/pipeline:insights-operator created  digest=sha256:2d97326884205f19496b2a7b3dbd2c74927ec28079a8971be11c9adeabc2d345 for-build=insights-operator
INFO[2025-12-18T00:12:10Z] Imported release 4.20.0-0.nightly-2025-12-17-043535 created at 2025-12-17 04:37:14 +0000 UTC with 192 images to tag release:latest 
INFO[2025-12-18T00:12:10Z] Tagging insights-operator into stable        
INFO[2025-12-18T00:12:10Z] Acquiring leases for test e2e-azure-techpreview: [azure4-quota-slice]

=> cca 11 minutes spent building unused images

Rehearsal: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/72743/rehearse-72743-periodic-ci-openshift-insights-operator-release-4.20-periodics-e2e-azure-techpreview/2001705297919348736

INFO[2025-12-18T17:29:30Z] ci-operator version v20251215-f0f4b3b2a      
...
INFO[2025-12-18T17:29:52Z] Importing release 4.20.0-0.nightly-2025-12-18-033027 created at 2025-12-18 03:32:22 +0000 UTC with 192 images to tag release:latest ... 
INFO[2025-12-18T17:31:44Z] Imported release 4.20.0-0.nightly-2025-12-18-033027 created at 2025-12-18 03:32:22 +0000 UTC with 192 images to tag release:latest 
INFO[2025-12-18T17:31:44Z] Acquiring leases for test e2e-azure-techpreview: [azure4-quota-slice]

=> builds eliminated, actual workflow starts ~2m into the execution

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@petr-muller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-insights-operator-release-4.20-periodics-insights-operator-e2e-tests-slow-tests 69a3cd5 link unknown /pj-rehearse periodic-ci-openshift-insights-operator-release-4.20-periodics-insights-operator-e2e-tests-slow-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants