Open
Conversation
8875098 to
d2fddd1
Compare
27f740f to
e3d8a17
Compare
This was referenced Feb 2, 2026
09d4103 to
c59d8ff
Compare
801b2d7 to
a380153
Compare
Collaborator
Author
|
we could consider switching to toml, that would drop ~10k lines of dependencies as yaml is heavy |
Collaborator
Author
|
refactored it to no longer use yaml files, but instead go files directly. This is not only simpler in terms of dependencies but allows us to update plans automatically too. so a win win. |
9fc3df4 to
be0dd68
Compare
Collaborator
Author
|
now that the dockerfile is separate to the test definitions, we could even consider referencing dockerfiles from integrationtests, this way we would always ensure that both plan is correct and we can indeed build the dockerfile too. |
mzihlmann
commented
Feb 8, 2026
mzihlmann
commented
Feb 8, 2026
ea212ba to
754f1f7
Compare
mzihlmann
commented
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adding a new kind of integration tests "golden tests"
The new features that come up are often concerned with performance improvements. These improvements are taken by not following the Dockerfile to the letter, but reorder and skip instructions where possible. It is both difficult to mentally model what exactly happens with an optimization and difficult to write tests that verify an optimization is indeed taken. Golden tests come to the rescue, basically kaniko learned a new --dryrun flag, which lets it print a plan instead of running commands. The plan shows what kaniko would be doing, this is after all optimizations were applied, in a sort of "intermediate representation". We can now simply compare the plan kaniko generates to a "golden plan" from a previous run and if there is a diff we most likely have a bug.
This will bring in a new dependency yaml. maybe we should separate productive and testing 3rparty?