Fix --no-headless flag not showing browser window#2
Open
keithschacht wants to merge 1 commit intoparruda:mainfrom
Open
Fix --no-headless flag not showing browser window#2keithschacht wants to merge 1 commit intoparruda:mainfrom
keithschacht wants to merge 1 commit intoparruda:mainfrom
Conversation
keithschacht
force-pushed
the
fix-headless-browser-visibility
branch
from
e32ea21 to
5ef7c10
Compare
The --no-headless flag was being passed correctly but SessionManager was hardcoded to always use :selenium_chrome_headless driver. This fix: - Adds register_driver method that respects the @Headless parameter - Changes from hardcoded headless driver to configurable :selenium_chrome - Only adds --headless argument to Chrome options when @Headless is true This allows the browser window to be visible when using --no-headless flag. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
keithschacht
force-pushed
the
fix-headless-browser-visibility
branch
from
8823d5a to
e52dec9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-headlessflag wasn't working - browser window remained hidden:selenium_chrome_headlessdriver regardless of the headless parameterThe Fix
register_drivermethod that dynamically configures the Chrome driver based on the@headlessinstance variablecreate_sessionto use the configurable:selenium_chromedriver instead of the hardcoded:selenium_chrome_headless--headlessargument only when@headlessis trueThis fix ensures developers can visually debug browser automation when needed by using the
--no-headlessflag.