Skip to content

Fix --no-headless flag not showing browser window #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keithschacht wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix --no-headless flag not showing browser window #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions lib/headless_browser_tool/session_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# frozen_string_literal: true

require "capybara"
require "selenium-webdriver"
require "json"
require "fileutils"
require_relative "logger"
Expand Down Expand Up @@ -97,12 +98,29 @@ def session_info

private

def register_driver
Capybara.register_driver :selenium_chrome do |app|
options = Selenium::WebDriver::Chrome::Options.new

# Basic arguments
options.add_argument("--headless") if @headless
options.add_argument("--no-sandbox")
options.add_argument("--disable-dev-shm-usage")
options.add_argument("--disable-gpu") if @headless

Capybara::Selenium::Driver.new(app, browser: :chrome, options: options)
end
end

def create_session(session_id)
HeadlessBrowserTool::Logger.log.info "Creating new Capybara session: #{session_id}"
HeadlessBrowserTool::Logger.log.info "Creating new Capybara session: #{session_id} (headless: #{@headless})"

# Register the appropriate driver before creating the session
register_driver

# Create a new Capybara session
# With threadsafe mode enabled, each session is isolated
session = Capybara::Session.new(:selenium_chrome_headless)
session = Capybara::Session.new(:selenium_chrome)

# Try to restore previous state
restore_session_state(session_id, session)
Expand Down