Merged
Conversation
missinglink
force-pushed
the
street_synonyms
branch
from
dcf07e5 to
a52cc00
Compare
Member
|
Tests look great. Do you think it might make more sense to put them in the existing search_abbreviations file? |
Member
|
Ah, one change to be made: there's a bug with the fuzzy-tester where combining |
orangejulius
force-pushed
the
street_synonyms
branch
from
a52cc00 to
b9a03b3
Compare
Member
Author
|
note the |
These are very similar, there's no need for a new test suite
Most of these should be fixed by pelias/schema#453
Member
|
I combined these tests with the existing search abbreviations test suite, and marked them pass/fail as of the current master branch of pelias/schema. After pelias/schema#453 we will have a party where we mark several of the tests passing again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Street Synonyms test cases to cover come of the cases in pelias/schema#453