Skip to content

Add Street Synonyms test cases #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orangejulius merged 5 commits into from
Jun 25, 2020
Merged

Add Street Synonyms test cases #522

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3aa8824
Add Street Synonyms test cases
missinglink Jun 22, 2020
b9a03b3
Use workaround for normalizer issue
orangejulius Jun 22, 2020
42c5155
Lower search abbreviations priorityThresh to 1
orangejulius Jun 25, 2020
9363518
Combine street synonym tests into search abbreviations suite
orangejulius Jun 25, 2020
f8f3baf
Mark abbreviation tests failing
orangejulius Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 151 additions & 2 deletions test_cases/search_abbreviations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "search abbreviations",
"priorityThresh": 5,
"priorityThresh": 1,
"tests": [
{
"id": 1,
Expand All @@ -24,7 +24,7 @@
}
},
{
"id": 2,
"id": 1.1,
"status": "fail",
"user": "julian",
"issue": "https://github.com/pelias/pelias/issues/737",
Expand All @@ -44,6 +44,34 @@
]
}
},
{
"id": 1.3,
"status": "pass",
"user": "missinglink",
"notes": ["Sainte != Saint && St == Street"],
"in": {
"text": "Sainte Patrick St, Donaldsonville, LA"
},
"unexpected": {
"properties": [
{ "street": "Saint Patrick Street" }
]
}
},
{
"id": 1.4,
"status": "pass",
"user": "missinglink",
"notes": ["St == Saint && Straße != Street"],
"in": {
"text": "St Patrick Straße, Donaldsonville, LA"
},
"unexpected": {
"properties": [
{ "street": "Saint Patrick Street" }
]
}
},
{
"id": 3,
"status": "pass",
Expand Down Expand Up @@ -108,6 +136,127 @@
}
]
}
},
{
"id": 6.1,
"status": "fail",
"user": "missinglink",
"notes": ["R == Rue"],
"in": {
"text": "R Gay Lussac, Paris"
},
"expected": {
"properties": [
{ "street": "Rue Gay-Lussac" }
]
}
},
{
"id": 6.2,
"status": "pass",
"user": "missinglink",
"notes": ["Rue == Rue"],
"in": {
"text": "Rue Gay Lussac, Paris"
},
"expected": {
"properties": [
{
"street": "Rue Gay-Lussac"
}
]
}
},
{
"id": 7.1,
"status": "fail",
"user": "missinglink",
"notes": ["Av. == Avenida"],
"in": {
"text": "Av. Juárez, Guadalajara, México"
},
"expected": {
"properties": [
{ "street": "Avenida Juárez" }
]
}
},
{
"id": 7.2,
"status": "pass",
"user": "missinglink",
"notes": ["Avenida == Avenida"],
"in": {
"text": "Avenida Juárez, Guadalajara, México"
},
"expected": {
"properties": [
{
"street": "Avenida Juárez"
}
]
}
},
{
"id": 7.3,
"status": "pass",
"user": "missinglink",
"notes": ["Avenue != Avenida"],
"in": {
"text": "Avenue Juárez, Guadalajara, México"
},
"unexpected": {
"properties": [
{
"street": "Avenida Juárez"
}
]
}
},
{
"id": 8.1,
"status": "fail",
"user": "missinglink",
"in": {
"text": "W Mt Hope Av. MI USA"
},
"expected": {
"properties": [
{
"street": "West Mount Hope Avenue"
}
]
}
},
{
"id": 8.2,
"status": "pass",
"user": "missinglink",
"in": {
"text": "West Mount Hope Avenue MI USA"
},
"expected": {
"properties": [
{
"street": "West Mount Hope Avenue"
}
]
}
},
{
"id": 9,
"status": "fail",
"user": "missinglink",
"in": {
"text": "E 98th Ter, MO, USA"
},
"expected": {
"properties": [
{
"street": "East 98th Terrace"
}
]
}
}
]
}