Skip to content

Conversation

@Xnopyt
Copy link
Collaborator

@Xnopyt Xnopyt commented Jul 30, 2025

This fixes several deprecation warnings thrown by this library when running on PHP 8.4 with E_DEPRECATED reporting enabled

PHP Deprecated:  Phlib\Beanstalk\Connection\Socket::read(): Implicitly marking parameter $length as nullable is deprecated, the explicit nullable type must be used instead in ./src/Connection/Socket.php on line 82
PHP Deprecated:  Phlib\Beanstalk\Exception\BuriedException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead in ./src/Exception/BuriedException.php on line 16
PHP Deprecated:  Phlib\Beanstalk\Connection::__construct(): Implicitly marking parameter $createSocket as nullable is deprecated, the explicit nullable type must be used instead in ./src/Connection.php on line 31

@chrisminett chrisminett self-assigned this Jul 31, 2025
@chrisminett chrisminett added the patch-version Release CAN be patch version increment label Jul 31, 2025
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.71%. Comparing base (97565e4) to head (6019785).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #40   +/-   ##
=========================================
  Coverage     98.71%   98.71%           
  Complexity      362      362           
=========================================
  Files            41       41           
  Lines          1168     1168           
=========================================
  Hits           1153     1153           
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrisminett chrisminett self-requested a review July 31, 2025 10:18
@chrisminett chrisminett merged commit bdf1669 into phlib:main Jul 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch-version Release CAN be patch version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants