Fix boolean types in ProductList::addCondition()#233
Merged
fashxp merged 2 commits intopimcore:2.xfrom Apr 18, 2025
Merged
Conversation
|
Member
|
@jremmurd Could you please rebase this PR to the 2.x branch? There won’t be a 1.4 release. Thanks! |
Member
|
thx very much! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Shorthand addCondition() for boolean fields in OpenSearch or ElasticSearch currently result in an error, as the boolean value gets auto converted to string "1".
This PR fixes the typing error (introducing a BC break).
Steps to reproduce
Workaround
Pass the strings "true" or "false" in the
addCondition()call, as it gets converted to bool values in the query later on.