Skip to content

Fix boolean types in ProductList::addCondition() #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fashxp merged 2 commits into from
Apr 18, 2025
Merged

Fix boolean types in ProductList::addCondition() #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca1cfc4
fix: missing boolean type for addCondition
jremmurd Feb 25, 2025
32618ae
Update 01_Upgrade_Notes.md
fashxp Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/03_Installation/01_Upgrade_Notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Upgrade Notes

#### v2.0.0
Added `bool` as possible type to `$condition` parameter of `addCondition` function in `ProductListInterface` (and all implementing classes).

#### v1.2.1
- Removed the package "rybakit/twig-deferred-extension". If you extend the twig layout from the E-Commerce Framework,
please check if custom CSS/JS code added by `pimcore_head_script` and `pimcore_head_link` is still working.
2 changes: 1 addition & 1 deletion src/IndexService/ProductList/DefaultFindologic.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public function getProducts(): array
return $this->products;
}

public function addCondition(array|string $condition, string $fieldname = ''): void
public function addCondition(array|string|bool $condition, string $fieldname = ''): void
{
$this->products = null;
$this->conditions[$fieldname][] = $condition;
Expand Down
2 changes: 1 addition & 1 deletion src/IndexService/ProductList/DefaultMysql.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function getProducts(): array

protected ?float $conditionPriceTo = null;

public function addCondition(array|string $condition, string $fieldname = ''): void
public function addCondition(array|string|bool $condition, string $fieldname = ''): void
{
$this->products = null;
$this->conditions[$fieldname][] = $condition;
Expand Down
2 changes: 1 addition & 1 deletion src/IndexService/ProductList/ElasticSearch/AbstractElasticSearch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public function setProductPositionMap(array $productPositionMap): static
*
* @param string $fieldname - must be set for elastic search
*/
public function addCondition(array|string $condition, string $fieldname = ''): void
public function addCondition(array|string|bool $condition, string $fieldname = ''): void
{
$this->filterConditions[$fieldname][] = $condition;
$this->preparedGroupByValuesLoaded = false;
Expand Down
2 changes: 1 addition & 1 deletion src/IndexService/ProductList/OpenSearch/AbstractOpenSearch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ public function setProductPositionMap(array $productPositionMap): static
*
* @param string $fieldname - must be set for elastic search
*/
public function addCondition(array|string $condition, string $fieldname = ''): void
public function addCondition(array|string|bool $condition, string $fieldname = ''): void
{
$this->filterConditions[$fieldname][] = $condition;
$this->preparedGroupByValuesLoaded = false;
Expand Down
2 changes: 1 addition & 1 deletion src/IndexService/ProductList/ProductListInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function getProducts(): array;
* and exclude functionality in group by results
*
*/
public function addCondition(array|string $condition, string $fieldname = ''): void;
public function addCondition(array|string|bool $condition, string $fieldname = ''): void;

/**
* Adds query condition to product list for fulltext search
Expand Down