Skip to content

br: add compact log backup #19832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 12 commits into from
Mar 12, 2025
Merged

br: add compact log backup #19832

ti-chi-bot merged 12 commits into from
Mar 12, 2025

Conversation

@YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Feb 13, 2025 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

This PR adds a new document for the new feature "compact log backup". (experimental)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2025
@lilin90 lilin90 changed the title added compact log backup br: add compact log backup Feb 13, 2025
@lilin90 lilin90 self-assigned this Feb 13, 2025
@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Feb 13, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Feb 13, 2025
@lilin90 lilin90 added the v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. label Feb 13, 2025
lilin90
lilin90 reviewed Feb 20, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2025
@lilin90 lilin90 requested a review from hfxsd February 20, 2025 09:11
@lilin90 lilin90 mentioned this pull request Feb 20, 2025
Merged
15 tasks
Tristan1900
Tristan1900 reviewed Feb 20, 2025
View reviewed changes
Tristan1900
Tristan1900 reviewed Feb 26, 2025
View reviewed changes
br/br-compact-log-backup.md Outdated
有了存储的 Base64 之后，你可以执行以下命令通过 `tikv-ctl` 发起压缩：

```shell
tikv-ctl compact-log-backup \
Copy link
Contributor

@Tristan1900 Tristan1900 Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可能要加一个--log-level=info 否则默认是warn，而且默认会打出来warning说log level不够

Tristan1900
Tristan1900 reviewed Feb 26, 2025
View reviewed changes
@Tristan1900
Copy link
Contributor

Tristan1900 commented Mar 3, 2025

/approve

BornChanger
BornChanger reviewed Mar 10, 2025
View reviewed changes
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 10, 2025

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90
Copy link
Member

lilin90 commented Mar 10, 2025

/retest

@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 11, 2025
BornChanger
BornChanger reviewed Mar 11, 2025
View reviewed changes
YuJuncen
YuJuncen commented Mar 11, 2025
View reviewed changes
YuJuncen
YuJuncen commented Mar 11, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2025
lilin90
lilin90 reviewed Mar 11, 2025
View reviewed changes
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 11, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 11, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 11, 2025

@hfxsd: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lilin90
lilin90 approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 12, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-11 13:54:38.966733616 +0000 UTC m=+277634.572262537: ☑️ agreed by hfxsd.
  • 2025-03-12 07:15:51.639563101 +0000 UTC m=+340107.245092027: ☑️ agreed by lilin90.

@lilin90
Copy link
Member

lilin90 commented Mar 12, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90, Tristan1900

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 12, 2025
@ti-chi-bot ti-chi-bot bot merged commit 22d799c into pingcap:master Mar 12, 2025
7 checks passed
@lilin90 lilin90 mentioned this pull request Mar 21, 2025
Merged
6 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 24, 2025
Merged
6 tasks
@lilin90 lilin90 added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 19, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 19, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #21205.

This was referenced Dec 19, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BornChanger BornChanger BornChanger approved these changes

@lilin90 lilin90 lilin90 approved these changes

@hfxsd hfxsd hfxsd approved these changes

+1 more reviewer

@Tristan1900 Tristan1900 Tristan1900 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lilin90 lilin90

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@YuJuncen @Tristan1900 @lilin90 @ti-chi-bot @hfxsd @BornChanger