[♻] Improve ZipFileMock constructor #1218
Merged
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJ
added a commit
that referenced
this pull request
Oct 17, 2022
# ✍️ Description Again, this was found wanting for #1218. This coupling was probably not needed, so that all information for an entry occurs in the entry itself, and it does not need to be handled by the hosting zipFile. Since this is a Mock, we don't really need more than that. ## ℹ️ Other information Might include some tests, and additional spin-off of all ZipMockFile methods that create Entries.
JJ
pushed a commit
that referenced
this pull request
Oct 18, 2022
fhd
reviewed
Oct 18, 2022
|
|
||
| async function analyzeZipWithFiles(files) { | ||
| const zipFile = new ZipFileMock(); | ||
| let dataFilePairs = []; |
Contributor
There was a problem hiding this comment.
Nit: This should still be possible to be const, since it's not being reassigned.
| expectActiveAnalysis, | ||
| expectAnalysisSuccessStatus, | ||
| } from "../utils/analysis-assertions"; | ||
| import { createMockedZip } from "../utils/data-creation"; |
Contributor
There was a problem hiding this comment.
Can createMockedZip be removed now?
Contributor
Author
There was a problem hiding this comment.
You mean, from all over? It's used in some other places. I'd have to check.
Contributor
Author
There was a problem hiding this comment.
Right, it can be removed. It's essentially doing what the new ctor is doing. Only... It's all over, as said. I'll probably just refactor it to avoid extensive changes.
added 3 commits
October 18, 2022 08:45
It's not needed with the new constructor, only it's all over...
fhd
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
While doing #1204, the need to refactor mocks arose. It became a bit hefty for an already heavy PR, so it's better taken outside.
🏗️ Working with PROD4POD-1931
ℹ️ Other information
I'll leave it as draft for the time being, since some functions might be unneeded after this. Feedback welcome anyway.