Conversation
bschwedler
force-pushed
the
add-image-param
branch
2 times, most recently
from
60cb211 to
6eab77c
Compare
|
@bschwedler are you still working on this? |
|
@nealrichardson I need to complete some additional testing with cross-repository image access for |
bschwedler
force-pushed
the
add-image-param
branch
3 times, most recently
from
6b0cd86 to
0c147f1
Compare
|
This should be good to go now. The following GHA run pulls from an
|
bschwedler
force-pushed
the
add-image-param
branch
2 times, most recently
from
e105eb2 to
0c6cb2d
Compare
This change allows specifying a custom container image for Posit Connect
bschwedler
force-pushed
the
add-image-param
branch
from
0c6cb2d to
f839f68
Compare
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
One question about the validation but otherwise this looks good to me, thanks!
main.py
Outdated
| base_image, tag = args.image.rsplit(":", 1) | ||
| except ValueError: | ||
| raise RuntimeError( | ||
| f"Invalid image format: '{args.image}'. Image must include a tag (e.g., rstudio/rstudio-connect:2025.09.0)" |
There was a problem hiding this comment.
Why is this invalid? Doesn't docker default to latest if you don't specify a tag?
There was a problem hiding this comment.
Good point.
The rest of the code relies on base_image and tag being separate. I'll default to latest if the tag isn't specified and write out an info/warning message.
There was a problem hiding this comment.
Successful run with the latest changes: https://github.com/posit-dev/images-examples/actions/runs/20347993740/job/58550102176
This also moves the logic into a helper function to make it easier to test.
2 participants
Add an image parameter to the action.
This simplifies running a specific image for Connect
The image must be specified with a tag (e.g.
rstudio/rstudio-connect:2025.12.0) and will override the defaultversion.The script and action will exit with an error if both
imageandversionare specified.