22. Generate Parentheses #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodchip
reviewed
Aug 22, 2025
| } | ||
| private: | ||
| void generateParenthesisHelper( | ||
| const int n, |
There was a problem hiding this comment.
関数の引数にプリミティブ型を渡す場合は const は付けないことが多いと思います。 n/num_open/num_close で const がついていたりついていなかったりするのも気になりました。
tokuhirat
reviewed
Aug 23, 2025
| int num_open, | ||
| int num_close, | ||
| vector<string>& result | ||
| ) { |
There was a problem hiding this comment.
好みの範囲かもしれませんが、num_open を これから parentheses に追加すべき数にすると n を渡さずに済むので好きです。お書きいただいた parentheses の中にある数を num_open とすると、重複している情報が渡されている点が気になりました（含まれている個数は数えたらわかるので）。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/generate-parentheses/description/