-
Notifications
You must be signed in to change notification settings - Fork 0
22. Generate Parentheses #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
potrue
wants to merge
1
commit into
main
Choose a base branch
from
22
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| ## 何も見ずに解いてみる | ||
|
|
||
| ```cpp | ||
| class Solution { | ||
| public: | ||
| vector<string> generateParenthesis(int n) { | ||
| vector<string> result; | ||
| string parenthesis; | ||
| generateParenthesisHelper(n, parenthesis, 0, 0, result); | ||
| return result; | ||
| } | ||
| private: | ||
| void generateParenthesisHelper( | ||
| const int n, | ||
| string& parenthesis, | ||
| int num_open, | ||
| int num_close, | ||
| vector<string>& result | ||
| ) { | ||
| if (num_close == n) { | ||
| result.emplace_back(parenthesis); | ||
| return; | ||
| } | ||
| if (num_open < n) { | ||
| parenthesis.push_back('('); | ||
| generateParenthesisHelper(n, parenthesis, num_open + 1, num_close, result); | ||
| parenthesis.pop_back(); | ||
| } | ||
| if (num_close < num_open) { | ||
| parenthesis.push_back(')'); | ||
| generateParenthesisHelper(n, parenthesis, num_open, num_close + 1, result); | ||
| parenthesis.pop_back(); | ||
| } | ||
| } | ||
| }; | ||
| ``` | ||
|
|
||
| ## 他の人のコードを見てみる | ||
|
|
||
| https://github.com/tokuhirat/LeetCode/pull/53/files | ||
| https://github.com/ryosuketc/leetcode_arai60/pull/42/files | ||
| https://github.com/Ryotaro25/leetcode_first60/pull/58/files | ||
|
|
||
| https://ja.wikipedia.org/wiki/%E3%82%AB%E3%82%BF%E3%83%A9%E3%83%B3%E6%95%B0 | ||
| 組み合わせの数はカタラン数というので求められるらしい。 | ||
|
|
||
| <img width="793" height="584" alt="image" src="https://github.com/user-attachments/assets/c42360dc-d14e-44c3-aab4-37737473ba83" /> | ||
|
|
||
| <img width="808" height="317" alt="image" src="https://github.com/user-attachments/assets/a1f604cc-8d61-4fb8-b685-246e59c4255b" /> | ||
|
|
||
| ナルホド | ||
|
|
||
| ## 最終コード | ||
|
|
||
| 値渡しにしている以上`num_open`や`num_close`についても`const`にしても動くので`n`だけ`const int`なのはどうなのかなーと思いつつ、これだけに`const`をつけていたほうが`n`は最後までトップダウンで動かさずに伝えますよというニュアンスが伝わる気がする。 | ||
|
|
||
| ```cpp | ||
| class Solution { | ||
| public: | ||
| vector<string> generateParenthesis(int n) { | ||
| vector<string> result; | ||
| string parentheses; | ||
| generateParenthesisHelper(n, parentheses, 0, 0, result); | ||
| return result; | ||
| } | ||
| private: | ||
| void generateParenthesisHelper( | ||
| const int n, | ||
| string& parentheses, | ||
| int num_open, | ||
| int num_close, | ||
| vector<string>& result | ||
| ) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 好みの範囲かもしれませんが、num_open を これから parentheses に追加すべき数にすると n を渡さずに済むので好きです。お書きいただいた parentheses の中にある数を num_open とすると、重複している情報が渡されている点が気になりました(含まれている個数は数えたらわかるので)。 |
||
| if (parentheses.size() == n * 2) { | ||
| result.emplace_back(parentheses); | ||
| return; | ||
| } | ||
| if (num_open < n) { | ||
| parentheses.push_back('('); | ||
| generateParenthesisHelper(n, parentheses, num_open + 1, num_close, result); | ||
| parentheses.pop_back(); | ||
| } | ||
| if (num_close < num_open) { | ||
| parentheses.push_back(')'); | ||
| generateParenthesisHelper(n, parentheses, num_open, num_close + 1, result); | ||
| parentheses.pop_back(); | ||
| } | ||
| } | ||
| }; | ||
| ``` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
関数の引数にプリミティブ型を渡す場合は const は付けないことが多いと思います。 n/num_open/num_close で const がついていたりついていなかったりするのも気になりました。