Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aca45bb2a3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const isCattaxMatch = metaCattax === cattax; | ||
| if ((catConfig.enforce && isCattaxMatch && bcat.some(category => [primaryCatId, ...secondaryCatIds].includes(category))) || | ||
| (catConfig.blockUnknown && (!isCattaxMatch || !primaryCatId))) { |
There was a problem hiding this comment.
Default missing bid meta cattax to 1 before matching
This comparison treats meta.cattax as required even though the change description says unspecified values should default to taxonomy 1: when a bid has primaryCatId but no meta.cattax, isCattaxMatch becomes false and the default cat.blockUnknown=true path rejects the bid as unknown. That will incorrectly drop bids for adapters that populate category IDs directly without meta.cattax (i.e. outside the ORTB converter path), so enabling bidResponseFilter can start rejecting valid categorized bids after this commit.
Useful? React with 👍 / 👎.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
closes #12481