Skip to content

Comments

bidResponseFilter: cattax handling#14428

Open
mkomorski wants to merge 3 commits intomasterfrom
mkomorski/cattax
Open

bidResponseFilter: cattax handling#14428
mkomorski wants to merge 3 commits intomasterfrom
mkomorski/cattax

Conversation

@mkomorski
Copy link
Collaborator

@mkomorski mkomorski commented Feb 9, 2026

  • ortbConverter carries over cattax from ORTB seatbid.bid.cattax into bid response's meta.cattax.
  • bidResponseFilter checks response categories (meta.primaryCatId/meta.secondaryCatIds) against requests' bcat only when meta.cattax matches the request's cattax. (When not specified, cattax defaults to 1).
  • When cattax does not match, the category is considered unknown for the purposes of filtering (and controlled by the blockUnknown config).

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

closes #12481

@mkomorski mkomorski marked this pull request as ready for review February 9, 2026 11:57
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aca45bb2a3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +50 to +52
const isCattaxMatch = metaCattax === cattax;
if ((catConfig.enforce && isCattaxMatch && bcat.some(category => [primaryCatId, ...secondaryCatIds].includes(category))) ||
(catConfig.blockUnknown && (!isCattaxMatch || !primaryCatId))) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Default missing bid meta cattax to 1 before matching

This comparison treats meta.cattax as required even though the change description says unspecified values should default to taxonomy 1: when a bid has primaryCatId but no meta.cattax, isCattaxMatch becomes false and the default cat.blockUnknown=true path rejects the bid as unknown. That will incorrectly drop bids for adapters that populate category IDs directly without meta.cattax (i.e. outside the ORTB converter path), so enabling bidResponseFilter can start rejecting valid categorized bids after this commit.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: cattax support in bidResponseFilter

1 participant