Skip to content

bidResponseFilter: cattax handling #14428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkomorski wants to merge 3 commits into
base: master
Choose a base branch
from
+124 −9
Open

bidResponseFilter: cattax handling #14428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aca45bb
bidResponseFilter: cattax handling
mkomorski Feb 9, 2026
62b91ec
Merge branch 'master' into mkomorski/cattax
mkomorski Feb 9, 2026
ab79161
default meta value
mkomorski Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libraries/ortbConverter/processors/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ export const DEFAULT_PROCESSORS = {
if (bid.ext?.eventtrackers) {
bidResponse.eventtrackers = (bidResponse.eventtrackers ?? []).concat(bid.ext.eventtrackers);
}
if (bid.cattax) {
bidResponse.meta.cattax = bid.cattax;
}
}
}
}
Expand Down
8 changes: 5 additions & 3 deletions modules/bidResponseFilter/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function reset() {
}

export function addBidResponseHook(next, adUnitCode, bid, reject, index = auctionManager.index) {
const {bcat = [], badv = []} = index.getOrtb2(bid) || {};
const {bcat = [], badv = [], cattax = 1} = index.getOrtb2(bid) || {};
const bidRequest = index.getBidRequest(bid);
const battr = bidRequest?.ortb2Imp[bid.mediaType]?.battr || index.getAdUnit(bid)?.ortb2Imp[bid.mediaType]?.battr || [];

Expand All @@ -43,11 +43,13 @@ export function addBidResponseHook(next, adUnitCode, bid, reject, index = auctio
advertiserDomains = [],
attr: metaAttr,
mediaType: metaMediaType,
cattax: metaCattax = 1,
} = bid.meta || {};

// checking if bid fulfills ortb2 fields rules
if ((catConfig.enforce && bcat.some(category => [primaryCatId, ...secondaryCatIds].includes(category))) ||
(catConfig.blockUnknown && !primaryCatId)) {
const isCattaxMatch = metaCattax === cattax;
if ((catConfig.enforce && isCattaxMatch && bcat.some(category => [primaryCatId, ...secondaryCatIds].includes(category))) ||
(catConfig.blockUnknown && (!isCattaxMatch || !primaryCatId))) {
Comment on lines +50 to +52
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Default missing bid meta cattax to 1 before matching

This comparison treats meta.cattax as required even though the change description says unspecified values should default to taxonomy 1: when a bid has primaryCatId but no meta.cattax, isCattaxMatch becomes false and the default cat.blockUnknown=true path rejects the bid as unknown. That will incorrectly drop bids for adapters that populate category IDs directly without meta.cattax (i.e. outside the ORTB converter path), so enabling bidResponseFilter can start rejecting valid categorized bids after this commit.

Useful? React with 👍 / 👎.

reject(BID_CATEGORY_REJECTION_REASON);
} else if ((advConfig.enforce && badv.some(domain => advertiserDomains.includes(domain))) ||
(advConfig.blockUnknown && !advertiserDomains.length)) {
Expand Down
122 changes: 116 additions & 6 deletions test/spec/modules/bidResponseFilter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ describe('bidResponseFilter', () => {
advertiserDomains: ['domain1.com', 'domain2.com'],
primaryCatId: 'EXAMPLE-CAT-ID',
attr: 'attr',
mediaType: 'banner'
mediaType: 'banner',
cattax: 1
}
};

Expand All @@ -85,7 +86,8 @@ describe('bidResponseFilter', () => {
meta: {
advertiserDomains: ['domain1.com', 'domain2.com'],
primaryCatId: 'BANNED_CAT1',
attr: 'attr'
attr: 'attr',
cattax: 1
}
};
mockAuctionIndex.getOrtb2 = () => ({
Expand All @@ -96,14 +98,118 @@ describe('bidResponseFilter', () => {
sinon.assert.calledWith(reject, BID_CATEGORY_REJECTION_REASON);
});

describe('cattax (category taxonomy) match', () => {
it('should reject with BID_CATEGORY_REJECTION_REASON when cattax matches and primaryCatId is in bcat blocklist', () => {
const reject = sinon.stub();
const call = sinon.stub();
const bid = {
meta: {
advertiserDomains: ['domain1.com'],
primaryCatId: 'BANNED_CAT1',
attr: 1,
mediaType: 'banner',
cattax: 1
}
};
mockAuctionIndex.getOrtb2 = () => ({
badv: [], bcat: ['BANNED_CAT1'], cattax: 1
});
mockAuctionIndex.getBidRequest = () => ({
mediaTypes: { banner: {} },
ortb2Imp: {}
});

addBidResponseHook(call, 'adcode', bid, reject, mockAuctionIndex);
sinon.assert.calledWith(reject, BID_CATEGORY_REJECTION_REASON);
sinon.assert.notCalled(call);
});

it('should pass when cattax matches and primaryCatId is not in bcat blocklist', () => {
const reject = sinon.stub();
const call = sinon.stub();
const bid = {
meta: {
advertiserDomains: ['domain1.com'],
primaryCatId: 'ALLOWED_CAT',
attr: 1,
mediaType: 'banner',
cattax: 1
}
};
mockAuctionIndex.getOrtb2 = () => ({
badv: [], bcat: ['BANNED_CAT1'], cattax: 1
});
mockAuctionIndex.getBidRequest = () => ({
mediaTypes: { banner: {} },
ortb2Imp: {}
});

addBidResponseHook(call, 'adcode', bid, reject, mockAuctionIndex);
sinon.assert.notCalled(reject);
sinon.assert.calledOnce(call);
});

it('should reject with BID_CATEGORY_REJECTION_REASON when cattax does not match (treat primaryCatId as unknown)', () => {
const reject = sinon.stub();
const call = sinon.stub();
const bid = {
meta: {
advertiserDomains: ['domain1.com'],
primaryCatId: 'ALLOWED_CAT',
attr: 1,
mediaType: 'banner',
cattax: 2
}
};
mockAuctionIndex.getOrtb2 = () => ({
badv: [], bcat: ['BANNED_CAT1'], cattax: 1
});
mockAuctionIndex.getBidRequest = () => ({
mediaTypes: { banner: {} },
ortb2Imp: {}
});

addBidResponseHook(call, 'adcode', bid, reject, mockAuctionIndex);
sinon.assert.calledWith(reject, BID_CATEGORY_REJECTION_REASON);
sinon.assert.notCalled(call);
});

it('should pass when cattax does not match and blockUnknown is false (do not treat as unknown)', () => {
const reject = sinon.stub();
const call = sinon.stub();
const bid = {
meta: {
advertiserDomains: ['domain1.com'],
primaryCatId: 'BANNED_CAT1',
attr: 1,
mediaType: 'banner',
cattax: 2
}
};
mockAuctionIndex.getOrtb2 = () => ({
badv: [], bcat: ['BANNED_CAT1'], cattax: 1
});
mockAuctionIndex.getBidRequest = () => ({
mediaTypes: { banner: {} },
ortb2Imp: {}
});
config.setConfig({ [MODULE_NAME]: { cat: { blockUnknown: false } } });

addBidResponseHook(call, 'adcode', bid, reject, mockAuctionIndex);
sinon.assert.notCalled(reject);
sinon.assert.calledOnce(call);
});
});

it('should reject the bid after failed ortb2 adv domains rule validation', () => {
const rejection = sinon.stub();
const call = sinon.stub();
const bid = {
meta: {
advertiserDomains: ['domain1.com', 'domain2.com'],
primaryCatId: 'VALID_CAT',
attr: 'attr'
attr: 'attr',
cattax: 1
}
};
mockAuctionIndex.getOrtb2 = () => ({
Expand All @@ -121,7 +227,8 @@ describe('bidResponseFilter', () => {
meta: {
advertiserDomains: ['validdomain1.com', 'validdomain2.com'],
primaryCatId: 'VALID_CAT',
attr: 'BANNED_ATTR'
attr: 'BANNED_ATTR',
cattax: 1
},
mediaType: 'video'
};
Expand Down Expand Up @@ -149,6 +256,7 @@ describe('bidResponseFilter', () => {
primaryCatId: 'BANNED_CAT1',
attr: 'valid_attr',
mediaType: 'banner',
cattax: 1
}
};

Expand Down Expand Up @@ -177,7 +285,8 @@ describe('bidResponseFilter', () => {
advertiserDomains: ['validdomain1.com', 'validdomain2.com'],
primaryCatId: undefined,
attr: 'valid_attr',
mediaType: 'banner'
mediaType: 'banner',
cattax: 1
}
};

Expand Down Expand Up @@ -207,7 +316,8 @@ describe('bidResponseFilter', () => {
advertiserDomains: ['validdomain1.com', 'validdomain2.com'],
primaryCatId: 'VALID_CAT',
attr: 6,
mediaType: 'audio'
mediaType: 'audio',
cattax: 1
},
};

Expand Down
Loading