New Adapter: Pixfuture by pixfuture-media · Pull Request #4117 · prebid/prebid-server

pixfuture-media · 2024-12-19T15:23:08Z

This Pixfuture Prebid Server Adapter enables seamless integration with Pixfuture's ad exchange, allowing publishers to leverage their demand through server-side header bidding. The adapter formats outgoing bid requests, processes incoming bid responses, and adheres to OpenRTB standards for efficient and privacy-compliant ad delivery.

adapters/pixfuture/pixfuture.go

github-actions · 2024-12-19T15:23:55Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 3f33089

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:49:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:64:	MakeBids		90.0%
total:									(statements)		91.4%

…t practices and improve clarity

github-actions · 2024-12-19T16:18:26Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 993f157

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:27:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:48:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:63:	MakeBids		90.0%
total:									(statements)		91.2%

adapters/pixfuture/pixfuture.go

static/bidder-info/pixfuture.yaml

pixfuture-media · 2024-12-27T14:10:09Z

received

…

On Tue, 24 Dec 2024 at 04:56, Ashish Garg ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In static/bidder-info/pixfuture.yaml <#4117 (comment)> : > @@ -0,0 +1,16 @@ +endpoint: "https://srv-adapter.pixfuture.com/pixservices" +maintainer: + email: ***@***.***" Sent an email for verification. Please reply with "received". — Reply to this email directly, view it on GitHub <#4117 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUDNEQT5OAVWPASNEC4GV732HEVTPAVCNFSM6AAAAABT5HIYBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRRG43DAOBRGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

pixfuture-media · 2025-01-07T19:48:45Z

I would like to ask for your help with reviewing a pull request [New Adapter: Pixfuture #4117].
Your feedback would be greatly appreciated.
When do you think you might be able to review this?
Thank you in advance for your time and effort.

github-actions · 2025-01-13T19:50:51Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 284c847

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:27:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:48:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:63:	MakeBids		90.0%
total:									(statements)		91.2%

adapters/pixfuture/pixfuture.go

pixfuture-media · 2025-10-28T13:36:07Z

Thank you, Sheridan,
We will fix it

adapters/pixfuture/pixfuture.go

github-actions · 2025-11-17T19:12:39Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 5d3bef4

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:78:	MakeBids		92.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:131:	getMediaTypeForBid	66.7%
total:									(statements)		76.9%

pixfuture-media · 2025-11-17T19:21:39Z

Dear Sheridan, we made the requested changes. Please review and approve the merge.

pixfuture-media · 2025-12-19T17:45:17Z

Hi team, please review our code and merge it.

scr-oath

Review Update - Pixfuture Adapter

Thanks for the continued work on this adapter. I've done a thorough re-review of the current state. Many of the earlier comments have been addressed (struct naming, alphabetical ordering in exchange/adapter_builders.go, use of http.MethodPost, deleted commented-out code, etc.). However, several issues remain unresolved:

🔴 BLOCKING

1. Alphabetical ordering in openrtb_ext/bidders.go (still broken)

BidderPixfuture is at the end of the coreBidderNames array (after BidderZmaticoo). It needs to be moved to its correct alphabetical position between BidderPGAMSsp and BidderPlaydigo. The const block is correct but the array is not.

2. Missing userMacro in cookie sync configuration (pixfuture.yaml)

The userSync.redirect section is missing a userMacro field. Without this, {{.UserMacro}} in the default RedirectURL template resolves to an empty string, meaning the /setuid callback receives uid= (empty) and no user ID is ever stored. The entire cookie sync becomes non-functional.

Please add the macro your sync endpoint uses to substitute the user ID, e.g.:

userSync:
  redirect:
    url: "https://sync.pixfuture.com/cookiesync?gdpr={{.GDPR}}&consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}"
    userMacro: "${UID}"

3. Cookie sync endpoint must redirect to PBS /setuid

As @bsardo and @bretg noted, the sync endpoint must ultimately redirect to the PBS host's /setuid endpoint. The {{.RedirectURL}} macro handles constructing that URL, but your server at sync.pixfuture.com/cookiesync must honor the redirect query parameter and redirect the user there with their UID appended. Please confirm this is working.

4. Missing GPP privacy parameters in sync URL

Add GPP macros for compliance with multi-state privacy frameworks:

&gpp={{.GPP}}&gpp_sid={{.GPPSID}}

🟡 SUGGESTIONS (non-blocking but strongly recommended)

5. Memory efficiency in loop patterns (pixfuture.go)

In MakeBids, the for _, bid := range loop copies each openrtb2.Bid struct (which is large). Use index-based iteration instead:

for i := range bidResp.SeatBid {
    for j := range bidResp.SeatBid[i].Bid {
        bid := &bidResp.SeatBid[i].Bid[j]
        bidType, err := getMediaTypeForBid(bid)
        // ...
        bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{
            Bid:     bid,
            BidType: bidType,
        })
    }
}

Also update getMediaTypeForBid to accept a pointer: func getMediaTypeForBid(bid *openrtb2.Bid).

6. Duplicate test files

supplemental/no_bids.json and supplemental/status_204.json are byte-identical (both test HTTP 204). Change no_bids.json to return HTTP 200 with an empty seatbid array to test the empty-bids code path at line 121.

7. Test coverage gaps

Consider adding tests for:

Malformed JSON response body (exercises error path at lines 88-92)
Multi-impression request (all current tests are single-impression)
Bid response with mtype field set (currently all tests use the ext.prebid.type fallback — none exercise the OpenRTB 2.6 MType code path)

✅ Previously raised comments that are now resolved

Struct renamed from PixfutureAdapter to adapter ✅
testdata directory replaced with pixfuturetest/exemplary + supplemental ✅
config.go changes reverted ✅
go.mod/go.sum no longer modified ✅
coverage.out no longer in the diff ✅
docs/pixfuture.md removed from PR ✅
exchange/adapter_builders.go alphabetical ordering fixed ✅
TestJsonSamples now calls RunJSONBidderTest ✅
minLength: 3 added to pix_id schema ✅
Uses http.MethodPost instead of "POST" ✅
Commented-out code deleted ✅
Uses adapters.IsResponseStatusCodeNoContent / CheckResponseStatusCodeForErrors ✅
GVL Vendor ID 839 verified ✅
Maintainer email verified ✅

github-actions · 2026-02-11T14:45:45Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c1f03ba

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:78:	MakeBids		92.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:131:	getMediaTypeForBid	66.7%
total:									(statements)		76.9%

Fix malformed JSON error handling in Pixfuture adapter

github-actions · 2026-02-13T19:12:12Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 0a39bde

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:78:	MakeBids		92.3%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:137:	getMediaTypeForBid	69.2%
total:									(statements)		77.6%

Fixed issue with macroses

github-actions · 2026-02-13T19:13:28Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 857c4c1

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:78:	MakeBids		92.3%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:137:	getMediaTypeForBid	69.2%
total:									(statements)		77.6%

Reordered by alphabet BidderPixfuture from the list of bidders.

fix order for BidderPixfuture,

github-actions · 2026-02-13T19:34:00Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, bac0bf5

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:78:	MakeBids		92.3%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:137:	getMediaTypeForBid	69.2%
total:									(statements)		77.6%

pixfuture-media · 2026-02-13T19:39:22Z

Hi Sheridan,

We have resolved the following issues:
Alphabetical Ordering: Fixed the ordering in openrtb_ext/bidders.go.
Cookie Sync Configuration: Fixed the missing userMacro in pixfuture.yaml.
Cookie Sync Endpoint: Updated the endpoint to ensure it correctly redirects to the PBS /setuid endpoint.
Please let us know once this code has been merged into production.

Best regards,
Vitali I.

pixfuture-media and others added 12 commits December 5, 2024 19:43

added initila Pixfuture adapter files and codesd

93e6573

Miodified vendors timewait

458fad1

Adding test file

d67a079

Added prams_test.go

a9fe81b

Changing pix endpoint to srv-adapter.pixfuture.com

606b185

Made changes in test.go

061b818

Addede changes to pixfuture_test.go

d0bc2e1

Merge branch 'prebid:master' into master

eec17ff

update coverage.out

cb8e3a7

added doc

bba6eed

fixing bags

22df0f8

Merge branch 'prebid:master' into master

3f33089

github-actions bot reviewed Dec 19, 2024

View reviewed changes

adapters/pixfuture/pixfuture.go Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 19, 2024

View reviewed changes

adapters/pixfuture/pixfuture.go Outdated Show resolved Hide resolved

pixfuture-media added 2 commits December 19, 2024 16:10

Fixed naming convention issue for Pixfuture adapter to align with bes…

a22b19e

…t practices and improve clarity

Merge branch 'master' of github.com:pixfuture-media/prebid-server

993f157

gargcreation1992 self-assigned this Dec 24, 2024

gargcreation1992 reviewed Dec 24, 2024

View reviewed changes

adapters/pixfuture/pixfuture.go Outdated Show resolved Hide resolved

gargcreation1992 reviewed Dec 24, 2024

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

gargcreation1992 reviewed Dec 24, 2024

View reviewed changes

static/bidder-info/pixfuture.yaml Show resolved Hide resolved

bsardo changed the title ~~New Pixfuture adapter~~ New Adapter: Pixfuture Jan 6, 2025

bsardo added the adapter label Jan 6, 2025

pixfuture-media requested a review from gargcreation1992 January 6, 2025 18:56

Merge branch 'prebid:master' into master

284c847

Made changes regarding github-actions

9e470a0

scr-oath reviewed Oct 27, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Outdated Show resolved Hide resolved

scr-oath reviewed Oct 27, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Outdated Show resolved Hide resolved

scr-oath reviewed Oct 27, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Outdated Show resolved Hide resolved

scr-oath reviewed Oct 27, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Outdated Show resolved Hide resolved

scr-oath reviewed Oct 27, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

Update code based on feedback received from Prebid team

d5dd656

pixfuture-media dismissed scr-oath’s stale review via d5dd656 November 14, 2025 19:04

github-actions bot reviewed Nov 14, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

github-actions bot reviewed Nov 14, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

github-actions bot reviewed Nov 14, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

github-actions bot reviewed Nov 14, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

github-actions bot reviewed Nov 14, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

github-actions bot reviewed Nov 14, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

Fix validation issues and clean code

5d3bef4

github-actions bot reviewed Nov 17, 2025

View reviewed changes

adapters/pixfuture/pixfuture.go Outdated Show resolved Hide resolved

scr-oath requested changes Feb 10, 2026

View reviewed changes

Merge branch 'prebid:master' into master

c1f03ba

Enhance bid response processing and error handling

0a39bde

Fix malformed JSON error handling in Pixfuture adapter

Add GPP and GPP SID to userSync URL

857c4c1

Fixed issue with macroses

pixfuture-media added 2 commits February 13, 2026 14:22

Remove BidderPixfuture from bidders list

89ae5f6

Reordered by alphabet BidderPixfuture from the list of bidders.

Add BidderPixfuture to the list of bidders

bac0bf5

fix order for BidderPixfuture,

Comments

Conversation

pixfuture-media commented Dec 19, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 19, 2024

Code coverage summary

pixfuture

Uh oh!

github-actions bot commented Dec 19, 2024

Code coverage summary

pixfuture

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pixfuture-media commented Dec 27, 2024 via email

Uh oh!

pixfuture-media commented Jan 7, 2025

Uh oh!

github-actions bot commented Jan 13, 2025

Code coverage summary

pixfuture

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pixfuture-media commented Oct 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 17, 2025

Code coverage summary

pixfuture

Uh oh!

pixfuture-media commented Nov 17, 2025

Uh oh!

pixfuture-media commented Dec 19, 2025

Uh oh!

scr-oath left a comment

Choose a reason for hiding this comment

Review Update - Pixfuture Adapter

🔴 BLOCKING

🟡 SUGGESTIONS (non-blocking but strongly recommended)

✅ Previously raised comments that are now resolved

Uh oh!

github-actions bot commented Feb 11, 2026

Code coverage summary

pixfuture

Uh oh!

github-actions bot commented Feb 13, 2026

Code coverage summary

pixfuture

Uh oh!

github-actions bot commented Feb 13, 2026

Code coverage summary

pixfuture

Uh oh!

github-actions bot commented Feb 13, 2026

Code coverage summary

pixfuture

Uh oh!

pixfuture-media commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants