New Adapter: Pixfuture

adapters/pixfuture/params_test.go

@@ -0,0 +1,71 @@
+package pixfuture
+
+import (
+	"encoding/json"
+	"testing"
+
+	"github.com/prebid/prebid-server/v3/openrtb_ext"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestValidParams(t *testing.T) {
+	validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
+	require.NoError(t, err, "Failed to fetch the json schema.")
+
+	tests := []struct {
+		name string
+		json string
+	}{
+		{
+			name: "Minimum length satisfied",
+			json: `{"pix_id": "123"}`,
+		},
+		{
+			name: "Longer valid string",
+			json: `{"pix_id": "abcdef"}`,
+		},
+	}
+
+	for _, tt := range tests {
+		tt := tt // capture range variable
+		t.Run(tt.name, func(t *testing.T) {
+			assert.NoErrorf(t, validator.Validate(openrtb_ext.BidderPixfuture, json.RawMessage(tt.json)), "Schema rejected valid params: %s", tt.json)
+		})
+	}
+}
+
+func TestInvalidParams(t *testing.T) {
+	validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
+	require.NoError(t, err, "Failed to fetch the json schema.")
+
+	tests := []struct {
+		name string
+		json string
+	}{
+		{
+			name: "Wrong type (integer)",
+			json: `{"pix_id": 123}`,
+		},
+		{
+			name: "Too short (minLength: 3)",
+			json: `{"pix_id": "ab"}`,
+		},
+		{
+			name: "Missing required pix_id",
+			json: `{}`,
+		},
+		{
+			name: "Empty string (violates minLength)",
+			json: `{"pix_id": ""}`,
+		},
+	}
+
+	for _, tt := range tests {
+		tt := tt // capture range variable
+		t.Run(tt.name, func(t *testing.T) {
+			err := validator.Validate(openrtb_ext.BidderPixfuture, json.RawMessage(tt.json))
+			assert.Errorf(t, err, "Schema allowed invalid params: %s", tt.json)
+		})
+	}
+}

adapters/pixfuture/pixfuture.go

@@ -0,0 +1,175 @@
+// Package pixfuture implements the Pixfuture adapter for Prebid Server.
+// It provides functionality to handle bid requests and responses according to Pixfuture's specifications
+package pixfuture
+
+import (
+	"fmt"
+	"net/http"
+
+	"github.com/prebid/openrtb/v20/openrtb2"
+	"github.com/prebid/prebid-server/v3/adapters"
+	"github.com/prebid/prebid-server/v3/config"
+	"github.com/prebid/prebid-server/v3/errortypes"
+	"github.com/prebid/prebid-server/v3/openrtb_ext"
+	"github.com/prebid/prebid-server/v3/util/iterutil"
+	"github.com/prebid/prebid-server/v3/util/jsonutil"
+)
+
+type adapter struct {
+	endpoint string
+}
+
+func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
+	return &adapter{
+		endpoint: config.Endpoint,
+	}, nil
+}
+
+func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
+
+	var errs []error
+	var adapterRequests []*adapters.RequestData
+	headers := http.Header{}
+	headers.Set("Content-Type", "application/json")
+	headers.Set("Accept", "application/json")
+
+	for imp := range iterutil.SlicePointerValues(request.Imp) {
+
+		var bidderExt adapters.ExtImpBidder
+		var pixfutureExt openrtb_ext.ImpExtPixfuture
+
+		if err := jsonutil.Unmarshal(imp.Ext, &bidderExt); err != nil {
+			errs = append(errs, err)
+			continue
+		}
+		if err := jsonutil.Unmarshal(bidderExt.Bidder, &pixfutureExt); err != nil {
+			errs = append(errs, err)
+			continue
+		}
+		if pixfutureExt.PixID == "" {
+			errs = append(errs, &errortypes.BadInput{Message: "Missing required parameter pix_id"})
+			continue
+		}
+
+		requestCopy := *request
+		requestCopy.Imp = []openrtb2.Imp{*imp} // slice notation with dereferencing
+
+		reqJSON, err := jsonutil.Marshal(requestCopy)
+		if err != nil {
+			errs = append(errs, err)
+			continue
+		}
+
+		adapterRequests = append(adapterRequests, &adapters.RequestData{
+			Method:  http.MethodPost,
+			Uri:     a.endpoint,
+			Body:    reqJSON,
+			Headers: headers,
+			ImpIDs:  []string{imp.ID},
+		})
+	}
+
+	if len(adapterRequests) == 0 && len(errs) > 0 {
+		return nil, errs
+	}
+	return adapterRequests, errs
+}
+
+func (a *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) {
+	if adapters.IsResponseStatusCodeNoContent(response) {
+		return nil, nil
+	}
+
+	if err := adapters.CheckResponseStatusCodeForErrors(response); err != nil {
+		return nil, []error{err}
+	}
+
+	var bidResp openrtb2.BidResponse
+	// Step 1: Check if body is empty to avoid unnecessary unmarshal overhead
+	if len(response.Body) == 0 {
+		return nil, nil // Or return a specific error if Pixfuture always expects a body
+	}
+
+	// Step 2: The Unmarshal call (Lines 88-92)
+	if err := jsonutil.Unmarshal(response.Body, &bidResp); err != nil {
+		return nil, []error{&errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Invalid response format: %s", err.Error()),
+		}}
+	}
+
+	// Pre-calculate total number of bids
+	expectedBids := 0
+	for i := range bidResp.SeatBid {
+		expectedBids += len(bidResp.SeatBid[i].Bid)
+	}
+
+	bidResponse := adapters.NewBidderResponseWithBidsCapacity(expectedBids)
+	bidResponse.Currency = bidResp.Cur
+
+	var errs []error
+	for i := range bidResp.SeatBid {
+		// Use index j to avoid copying the large openrtb2.Bid struct
+		for j := range bidResp.SeatBid[i].Bid {
+			bid := &bidResp.SeatBid[i].Bid[j]
+
+			bidType, err := getMediaTypeForBid(bid)
+			if err != nil {
+				errs = append(errs, &errortypes.BadServerResponse{
+					Message: "Failed to parse impression \"" + bid.ImpID + "\" mediatype",
+				})
+				continue
+			}
+
+			bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{
+				Bid:     bid,
+				BidType: bidType,
+			})
+		}
+	}
+
+	if len(bidResponse.Bids) == 0 {
+		return nil, errs
+	}
+
+	return bidResponse, errs
+}
+
+func getMediaTypeForBid(bid *openrtb2.Bid) (openrtb_ext.BidType, error) {
+	// First try standard MType field (OpenRTB 2.6)
+	switch bid.MType {
+	case openrtb2.MarkupBanner:
+		return openrtb_ext.BidTypeBanner, nil
+	case openrtb2.MarkupVideo:
+		return openrtb_ext.BidTypeVideo, nil
+	case openrtb2.MarkupNative:
+		return openrtb_ext.BidTypeNative, nil
+	}
+
+	// Fallback to custom extension
+	var ext struct {
+		Prebid struct {
+			Type string `json:"type"`
+		} `json:"prebid"`
+	}
+
+	if len(bid.Ext) > 0 {
+		if err := jsonutil.Unmarshal(bid.Ext, &ext); err != nil {
+			return "", &errortypes.BadServerResponse{
+				Message: fmt.Sprintf("Failed to parse bid ext for impression %s: %v", bid.ImpID, err),
+			}
+		}
+	}
+
+	switch ext.Prebid.Type {
+	case "banner":
+		return openrtb_ext.BidTypeBanner, nil
+	case "video":
+		return openrtb_ext.BidTypeVideo, nil
+	case "native":
+		return openrtb_ext.BidTypeNative, nil
+	default:
+		return "", &errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Unknown bid type for impression %s", bid.ImpID),
+		}
+	}
+}

adapters/pixfuture/pixfuture_test.go

@@ -0,0 +1,19 @@
+package pixfuture
+
+import (
+	"testing"
+
+	"github.com/prebid/prebid-server/v3/adapters/adapterstest"
+	"github.com/prebid/prebid-server/v3/config"
+	"github.com/prebid/prebid-server/v3/openrtb_ext"
+	"github.com/stretchr/testify/require"
+)
+
+func TestJsonSamples(t *testing.T) {
+	bidder, buildErr := Builder(openrtb_ext.BidderPixfuture, config.Adapter{
+		Endpoint: "http://any.url",
+	}, config.Server{})
+	require.NoError(t, buildErr, "Builder returned unexpected error")
+
+	adapterstest.RunJSONBidderTest(t, "pixfuturetest", bidder)
+}

adapters/pixfuture/pixfuturetest/exemplary/banner-site.json

@@ -0,0 +1,111 @@
+{
+  "mockBidRequest": {
+    "id": "test-request-id",
+    "site": {
+      "page": "test.com",
+      "publisher": {
+        "id": "123456789"
+      }
+    },
+    "imp": [
+      {
+        "id": "imp1",
+        "banner": {
+          "w": 300,
+          "h": 250
+        },
+        "ext": {
+          "bidder": {
+            "pix_id": "55463"
+          }
+        }
+      }
+    ]
+  },
+  "httpCalls": [
+    {
+      "expectedRequest": {
+        "uri": "http://any.url",
+        "headers": {
+          "Content-Type": [
+            "application/json"
+          ],
+          "Accept": [
+            "application/json"
+          ]
+        },
+        "body": {
+          "id": "test-request-id",
+          "site": {
+            "page": "test.com",
+            "publisher": {
+              "id": "123456789"
+            }
+          },
+          "imp": [
+            {
+              "id": "imp1",
+              "banner": {
+                "w": 300,
+                "h": 250
+              },
+              "ext": {
+                "bidder": {
+                  "pix_id": "55463"
+                }
+              }
+            }
+          ]
+        },
+        "impIDs": [
+          "imp1"
+        ]
+      },
+      "mockResponse": {
+        "status": 200,
+        "body": {
+          "id": "test-response-id",
+          "cur": "USD",
+          "seatbid": [
+            {
+              "bid": [
+                {
+                  "id": "bid1",
+                  "impid": "imp1",
+                  "price": 1.23,
+                  "adm": "<div>Banner Ad</div>",
+                  "ext": {
+                    "prebid": {
+                      "type": "banner"
+                    }
+                  }
+                }
+              ]
+            }
+          ]
+        }
+      }
+    }
+  ],
+  "expectedBidResponses": [
+    {
+      "bids": [
+        {
+          "bid": {
+            "id": "bid1",
+            "impid": "imp1",
+            "price": 1.23,
+            "adm": "<div>Banner Ad</div>",
+            "ext": {
+              "prebid": {
+                "type": "banner"
+              }
+            }
+          },
+          "type": "banner"
+        }
+      ],
+      "currency": "USD"
+    }
+  ]
+}