Fix: Require explicit GVL vendor ID declaration for aliases#4683
Open
bsardo wants to merge 2 commits intoprebid:masterfrom
Open
Fix: Require explicit GVL vendor ID declaration for aliases#4683bsardo wants to merge 2 commits intoprebid:masterfrom
bsardo wants to merge 2 commits intoprebid:masterfrom
Conversation
… the GVL entry represents them
46660d2 to
32e8b30
Compare
9 tasks
SyntaxNode
reviewed
Feb 10, 2026
| } | ||
| if aliasBidderInfo.GVLVendorID == 0 { | ||
| aliasBidderInfo.GVLVendorID = parentBidderInfo.GVLVendorID | ||
| } |
Contributor
There was a problem hiding this comment.
Please add a comment in this method explaining the GVLVendorID is specifically excluded, and why, so it isn't seen as a mistake and changed in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Removes logic that allows aliases to inherit the GVL ID from its parent
Explicitly declares the same GVL ID for the aliases as its parent when it is clear the alias and parent are the same entity:
The following aliases are currently inheriting a GVL ID from the parent but IMO it is not clear that the alias should use the same GVL ID as the parent. Some of these though do appear to have their own GVL entries in the latest Global Vendor List:
We need to decide how to handle these.