Skip to content

Comments

Fix: Require explicit GVL vendor ID declaration for aliases#4683

Open
bsardo wants to merge 2 commits intoprebid:masterfrom
bsardo:issue-3861-aliases-inheriting-gvl-ids
Open

Fix: Require explicit GVL vendor ID declaration for aliases#4683
bsardo wants to merge 2 commits intoprebid:masterfrom
bsardo:issue-3861-aliases-inheriting-gvl-ids

Conversation

@bsardo
Copy link
Collaborator

@bsardo bsardo commented Feb 10, 2026

This PR does the following:
Removes logic that allows aliases to inherit the GVL ID from its parent
Explicitly declares the same GVL ID for the aliases as its parent when it is clear the alias and parent are the same entity:

  • admaticde
  • epsilon (conversant rebranding)
  • equativ (owns smartadserver)
  • freewheel-ssp
  • magnite
  • showheroes-bs
  • showheroesBs
  • ttd
  • yahooAdvertisting
  • yahoossp

The following aliases are currently inheriting a GVL ID from the parent but IMO it is not clear that the alias should use the same GVL ID as the parent. Some of these though do appear to have their own GVL entries in the latest Global Vendor List:

  • adform (alias of adf)
  • copper6 (alias of adtelligent) —> should probably be 1356 according to latest GVL
  • finative (alias of seedingalliance)
  • indicue (alias of adtelligent)
  • janet (alias of adtelligent)
  • monetixads (alias of admatic)
  • netaddiction (alias of admatic)
  • pgam (alias of adtelligent) —> should probably be 1353 according to latest GVL
  • pixad (alias of admatic)
  • rxnetwork (alias of adkernel)
  • streamkey (alias of adtelligent)
  • tagoras (alias of vidazoo) —> should probably be 1450 according to latest GVL
  • xapads (alias of adkernel) —> should probably be 1320 according to latest GVL
  • yobee (alias of admatic)
    We need to decide how to handle these.

@bsardo bsardo added the PBS 4.0 label Feb 10, 2026
@bsardo bsardo force-pushed the issue-3861-aliases-inheriting-gvl-ids branch from 46660d2 to 32e8b30 Compare February 10, 2026 05:14
}
if aliasBidderInfo.GVLVendorID == 0 {
aliasBidderInfo.GVLVendorID = parentBidderInfo.GVLVendorID
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment in this method explaining the GVLVendorID is specifically excluded, and why, so it isn't seen as a mistake and changed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants