Skip to content

Fix: Require explicit GVL vendor ID declaration for aliases #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bsardo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Require explicit GVL vendor ID declaration for aliases #4683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
483e310
Fix: Require explicit GVL vendor ID declaration for aliases
bsardo Feb 10, 2026
32e8b30
Explicitly declare same GVL ID for aliases as parent when it is clear…
bsardo Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions config/bidderinfo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,6 @@ func processBidderAliases(aliasNillableFieldsByBidder map[string]aliasNillableFi
if aliasBidderInfo.ExtraAdapterInfo == "" {
aliasBidderInfo.ExtraAdapterInfo = parentBidderInfo.ExtraAdapterInfo
}
if aliasBidderInfo.GVLVendorID == 0 {
aliasBidderInfo.GVLVendorID = parentBidderInfo.GVLVendorID
}
Copy link
Contributor

@SyntaxNode SyntaxNode Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment in this method explaining the GVLVendorID is specifically excluded, and why, so it isn't seen as a mistake and changed in the future.

if aliasBidderInfo.Maintainer == nil {
aliasBidderInfo.Maintainer = parentBidderInfo.Maintainer
}
Expand Down
3 changes: 2 additions & 1 deletion config/bidderinfo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ func TestProcessBidderInfo(t *testing.T) {
},
},
ExtraAdapterInfo: "extra-info",
GVLVendorID: 42,
GVLVendorID: 0,
Maintainer: &MaintainerInfo{
Email: "some-email@domain.com",
},
Expand Down Expand Up @@ -392,6 +392,7 @@ func TestProcessAliasBidderInfo(t *testing.T) {
}
bidderB := parentWithSyncerKey
bidderB.AliasOf = "bidderA"
bidderB.GVLVendorID = 0
bidderB.Syncer = &Syncer{
Key: bidderB.Syncer.Key,
}
Expand Down
3 changes: 2 additions & 1 deletion static/bidder-info/admaticde.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: "admatic"
aliasOf: "admatic"
gvlVendorID: 1281
1 change: 1 addition & 0 deletions static/bidder-info/epsilon.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
aliasOf: conversant
gvlVendorID: 24
userSync:
redirect:
url: "https://prebid-match.dotomi.com/match/bounce/current?version=1&networkId=72582&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&rurl={{.RedirectURL}}"
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/equativ.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: "smartadserver"
gvlVendorID: 45
1 change: 1 addition & 0 deletions static/bidder-info/freewheel-ssp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
aliasOf: freewheelssp
gvlVendorID: 285
userSync:
iframe:
url: "https://ads.stickyadstv.com/pbs-user-sync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&r={{.RedirectURL}}"
Expand Down
3 changes: 2 additions & 1 deletion static/bidder-info/magnite.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: "rubicon"
aliasOf: "rubicon"
gvlVendorID: 52
3 changes: 2 additions & 1 deletion static/bidder-info/showheroes-bs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: "showheroes"
aliasOf: "showheroes"
gvlVendorID: 111
3 changes: 2 additions & 1 deletion static/bidder-info/showheroesBs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: "showheroes"
aliasOf: "showheroes"
gvlVendorID: 111
1 change: 1 addition & 0 deletions static/bidder-info/ttd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: thetradedesk
gvlVendorID: 21
1 change: 1 addition & 0 deletions static/bidder-info/yahooAdvertising.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
aliasOf: yahooAds
gvlVendorID: 25
userSync:
# yahooAdvertising supports user syncing, but requires configuration by the host. contact this
# bidder directly at the email address in this file to ask about enabling user sync.
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/yahoossp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
aliasOf: yahooAds
maintainer:
email: "hb-fe-tech@oath.com"
gvlVendorID: 25
userSync:
# yahoossp supports user syncing, but requires configuration by the host. contact this
# bidder directly at the email address in this file to ask about enabling user sync.
Expand Down
Loading