Skip to content

Conversation

@sabags
Copy link

@sabags sabags commented Dec 1, 2025

Description

Update CI to run with Ubuntu 22 instead of Ubuntu 20 since semaphore has ended support for Ubuntu 20.

Related issues/PRs

N/A

Todos

  • Tests
  • Documentation
  • Release note

Release Note

N/A

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.

@marvin-tigera marvin-tigera added this to the Calico v3.32.0 milestone Dec 1, 2025
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Dec 1, 2025
@sabags sabags marked this pull request as ready for review December 1, 2025 21:21
@sabags sabags requested a review from a team as a code owner December 1, 2025 21:21
Copilot AI review requested due to automatic review settings December 1, 2025 21:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Semaphore CI configuration to use Ubuntu 22.04 instead of Ubuntu 20.04 as the base OS image for CI agents across all pipeline definitions.

Key Changes:

  • Updated os_image field from ubuntu2004 to ubuntu2204 in all Semaphore CI configuration files

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
whisker/.semaphore/semaphore.yml Updated CI agent OS image to Ubuntu 22.04 for Whisker UI builds
.semaphore/semaphore.yml.d/blocks/40-openstack.yml Updated CI agent OS image to Ubuntu 22.04 for OpenStack testing block
.semaphore/semaphore.yml.d/blocks/20-node.yml Updated CI agent OS image to Ubuntu 22.04 for node testing block
.semaphore/semaphore.yml.d/blocks/20-e2e.yml Updated CI agent OS image to Ubuntu 22.04 for E2E testing block
.semaphore/semaphore.yml Updated CI agent OS image to Ubuntu 22.04 for main CI pipeline (E2E, node, and OpenStack blocks)
.semaphore/semaphore-scheduled-builds.yml Updated CI agent OS image to Ubuntu 22.04 for scheduled builds pipeline (E2E, node, and OpenStack blocks)

@caseydavenport caseydavenport added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Dec 1, 2025
@marvin-tigera marvin-tigera removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Dec 1, 2025
@caseydavenport
Copy link
Member

/sem-approve

1 similar comment
@caseydavenport
Copy link
Member

/sem-approve

@caseydavenport caseydavenport added the docs-pr-required Change is not yet documented label Dec 2, 2025
@marvin-tigera marvin-tigera removed the docs-pr-required Change is not yet documented label Dec 2, 2025
@sabags
Copy link
Author

sabags commented Dec 2, 2025

What you think of the test results here @caseydavenport ? Don't think they are a result of my changes

@caseydavenport
Copy link
Member

It seems unlikely to me, but I am not very familiar with those tests.

@caseydavenport
Copy link
Member

@sabags it does seem to be pretty consistent, though. So probably needs investigation.

@nelljerram
Copy link
Member

@sabags Please update the PR description to record why we are doing this.

For reasons that I don't fully understand:

1. This wasn't needed on Ubuntu Focal, but is on Jammy.  Perhaps a change to the system umask?

2. This is needed with Yoga on Jammy, but not with Caracal on Jammy.  Perhaps because Caracal added
code to add the +x permission dynamically?
@nelljerram
Copy link
Member

/sem-approve

@nelljerram
Copy link
Member

@sabags It looks like there's something odd about how you've set up this fork repo. First of all, Semaphore doesn't run automatically for it. Secondly, in #11487 I couldn't select it as an alternative base repo. Do you know why this is?

@nelljerram nelljerram mentioned this pull request Dec 5, 2025
3 tasks
@sabags
Copy link
Author

sabags commented Dec 5, 2025

First of all, Semaphore doesn't run automatically for it. Secondly, in #11487 I couldn't select it as an alternative base repo. Do you know why this is?

Could the first one be a permission issue ? My PRs were never able to run automatically unless a core maintainer or a member that had access to the projectcalico repo typed sem-approve. It looks like I don't have access to the semaphore ci account for projectcalico. I just checked if I could re-run the failed pipeline from UI but no such options show for me.

I am not sure about the second one at all.

@nelljerram
Copy link
Member

@sabags I would guess a group membership issue - suggest asking our #it guys to review that.

@nelljerram
Copy link
Member

/sem-approve

@nelljerram
Copy link
Member

/sem-approve

1 similar comment
@sabags
Copy link
Author

sabags commented Dec 18, 2025

/sem-approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants