-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[DE-3759] Update semaphore os_agent from Ubuntu 20.04 to Ubuntu 22.04 #11466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Semaphore CI configuration to use Ubuntu 22.04 instead of Ubuntu 20.04 as the base OS image for CI agents across all pipeline definitions.
Key Changes:
- Updated
os_imagefield fromubuntu2004toubuntu2204in all Semaphore CI configuration files
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| whisker/.semaphore/semaphore.yml | Updated CI agent OS image to Ubuntu 22.04 for Whisker UI builds |
| .semaphore/semaphore.yml.d/blocks/40-openstack.yml | Updated CI agent OS image to Ubuntu 22.04 for OpenStack testing block |
| .semaphore/semaphore.yml.d/blocks/20-node.yml | Updated CI agent OS image to Ubuntu 22.04 for node testing block |
| .semaphore/semaphore.yml.d/blocks/20-e2e.yml | Updated CI agent OS image to Ubuntu 22.04 for E2E testing block |
| .semaphore/semaphore.yml | Updated CI agent OS image to Ubuntu 22.04 for main CI pipeline (E2E, node, and OpenStack blocks) |
| .semaphore/semaphore-scheduled-builds.yml | Updated CI agent OS image to Ubuntu 22.04 for scheduled builds pipeline (E2E, node, and OpenStack blocks) |
|
/sem-approve |
1 similar comment
|
/sem-approve |
|
What you think of the test results here @caseydavenport ? Don't think they are a result of my changes |
|
It seems unlikely to me, but I am not very familiar with those tests. |
|
@sabags it does seem to be pretty consistent, though. So probably needs investigation. |
|
@sabags Please update the PR description to record why we are doing this. |
For reasons that I don't fully understand: 1. This wasn't needed on Ubuntu Focal, but is on Jammy. Perhaps a change to the system umask? 2. This is needed with Yoga on Jammy, but not with Caracal on Jammy. Perhaps because Caracal added code to add the +x permission dynamically?
|
/sem-approve |
Could the first one be a permission issue ? My PRs were never able to run automatically unless a core maintainer or a member that had access to the projectcalico repo typed sem-approve. It looks like I don't have access to the semaphore ci account for projectcalico. I just checked if I could re-run the failed pipeline from UI but no such options show for me. I am not sure about the second one at all. |
|
@sabags I would guess a group membership issue - suggest asking our #it guys to review that. |
|
/sem-approve |
|
/sem-approve |
1 similar comment
|
/sem-approve |
Description
Update CI to run with Ubuntu 22 instead of Ubuntu 20 since semaphore has ended support for Ubuntu 20.
Related issues/PRs
N/A
Todos
Release Note
N/A
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.