WIP for DE-3759 #11487
WIP for DE-3759 #11487
Conversation
marvin-tigera
added
release-note-required
nelljerram
added
docs-not-required
There was a problem hiding this comment.
Pull request overview
This PR upgrades the CI/CD infrastructure from Ubuntu 20.04 to Ubuntu 22.04 and adds support for conditionally disabling BIRD BGP configuration in DevStack-based OpenStack tests.
Key changes:
- Updates SemaphoreCI configuration to use ubuntu2204 instead of ubuntu2004 across multiple build agents
- Adds CALICO_BGP_MODE environment variable support to the DevStack plugin to conditionally install and configure BIRD
- Disables BIRD in single-node OpenStack test setups where it's not needed and causes errors
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| whisker/.semaphore/semaphore.yml | Updates OS image from ubuntu2004 to ubuntu2204 for Whisker UI CI builds |
| networking-calico/devstack/plugin.sh | Adds conditional logic to only install and configure BIRD when CALICO_BGP_MODE=bird, allowing it to be disabled for single-node setups |
| .semaphore/semaphore.yml.d/blocks/40-openstack.yml | Updates OS image and adds CALICO_BGP_MODE=none export to disable broken BIRD configuration in OpenStack tests |
| .semaphore/semaphore.yml.d/blocks/20-node.yml | Updates OS image from ubuntu2004 to ubuntu2204 for node builds |
| .semaphore/semaphore.yml.d/blocks/20-e2e.yml | Updates OS image from ubuntu2004 to ubuntu2204 for E2E tests |
| .semaphore/semaphore.yml | Generated file with OS image updates (requires regeneration to include CALICO_BGP_MODE changes) |
| .semaphore/semaphore-scheduled-builds.yml | Generated file with OS image updates (requires regeneration to include CALICO_BGP_MODE changes) |
| os_image: ubuntu2204 | ||
| prologue: | ||
| commands: | ||
| - cd networking-calico |
There was a problem hiding this comment.
This generated file is missing the CALICO_BGP_MODE=none export that was added to the template file .semaphore/semaphore.yml.d/blocks/40-openstack.yml. According to the repository guidelines, after modifying templates in .semaphore/semaphore.yml.d, you must run make gen-semaphore-yaml to regenerate this file. The missing export will cause the DevStack jobs to still attempt to configure BIRD, which according to the comments in the template "is thoroughly broken and generates loads of errors in the log."
| - cd networking-calico | |
| - cd networking-calico | |
| - export CALICO_BGP_MODE=none |
| os_image: ubuntu2204 | ||
| prologue: | ||
| commands: | ||
| - cd networking-calico |
There was a problem hiding this comment.
This generated file is missing the CALICO_BGP_MODE=none export that was added to the template file .semaphore/semaphore.yml.d/blocks/40-openstack.yml. According to the repository guidelines, after modifying templates in .semaphore/semaphore.yml.d, you must run make gen-semaphore-yaml to regenerate this file. The missing export will cause the DevStack jobs to still attempt to configure BIRD, which according to the comments in the template "is thoroughly broken and generates loads of errors in the log."
| - cd networking-calico | |
| - cd networking-calico | |
| - export CALICO_BGP_MODE=none |
The BIRD config in our DevStack setup is thoroughly broken and generates loads of errors in the log. But we don't need it for a single node setup anyway, so let's disable it.
For reasons that I don't fully understand: 1. This wasn't needed on Ubuntu Focal, but is on Jammy. Perhaps a change to the system umask? 2. This is needed with Yoga on Jammy, but not with Caracal on Jammy. Perhaps because Caracal added code to add the +x permission dynamically?
This reverts commit e329b52.
This reverts commit c212a21.
This reverts commit c086402.
nelljerram
force-pushed
the
de-3759
branch
2 times, most recently
from
e6c66b3 to
41e06f9
Compare
marvin-tigera
removed
docs-not-required
3 participants
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.