apb_to_reg: Replace modport with struct in default converter #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phsauter
force-pushed
the
phsauter/apb_to_reg_v2
branch
3 times, most recently
from
0a6992d to
52df9e0
Compare
phsauter
force-pushed
the
phsauter/apb_to_reg_v2
branch
from
52df9e0 to
b5a3beb
Compare
phsauter
force-pushed
the
phsauter/apb_to_reg_v2
branch
from
b5a3beb to
3880be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is awkward to not have a converter without interfaces and leads to odd code choices elsewhere (eg https://github.com/pulp-platform/clic/blob/master/src/clic_apb.sv#L59).
This PR deprecated apb_to_reg and replaces it with apb_to_reg_v2. Note that the interface only version (apt_to_reg_intf) is not changed and moved to apv_to_reg_v2.sv since this one should not be deprecated.