-
Notifications
You must be signed in to change notification settings - Fork 65
WIP: [DO NOT MERGE] fix docs site publishing #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,6 +6,7 @@ on: | |||||
| push: | ||||||
| branches: | ||||||
| - main | ||||||
| - fix-publishing | ||||||
|
|
||||||
| concurrency: | ||||||
| group: ${{ github.workflow }}-${{ github.ref }} | ||||||
|
|
@@ -42,11 +43,11 @@ jobs: | |||||
| aws-region: ${{ vars.AWS_REGION }} | ||||||
| role-duration-seconds: 7200 # 2h | ||||||
|
|
||||||
| - name: Fetch doc files from S3 | ||||||
| run: ci/download_from_s3.sh | ||||||
| # - name: Fetch doc files from S3 | ||||||
| # run: ci/download_from_s3.sh | ||||||
|
|
||||||
| - name: Post-process docs | ||||||
| run: ci/post-process.sh | ||||||
| # - name: Post-process docs | ||||||
| # run: ci/post-process.sh | ||||||
|
|
||||||
| - name: Deploy site | ||||||
| env: | ||||||
|
|
@@ -57,9 +58,7 @@ jobs: | |||||
| run: | | ||||||
| npm install --global --force @aschmidt8/netlify-cli | ||||||
|
|
||||||
| ARGS="" | ||||||
| if [ "$GITHUB_REF_NAME" = "main" ]; then | ||||||
| ARGS="--prod" | ||||||
| fi | ||||||
| netlify deploy "$ARGS" \ | ||||||
| netlify deploy \ | ||||||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looked for the available flags like this: docker run \
--rm \
-it node:lts-alpine3.23 \
sh
npm install --global --force @aschmidt8/netlify-cli
netlify deploy --helpHopefully getting more logs will help us here.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seeing some interesting things in the debug logs (logs link).
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Next I looked into the configuration for the site: docs/.github/workflows/deploy.yaml Lines 53 to 54 in 31497b6
Updated Then updated https://github.com/rapidsai/docs/actions/runs/21077092892/job/60621594737 Confirmed in this new build on |
||||||
| --prod \ | ||||||
| --debug \ | ||||||
| --dir=_site | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publishing from this branch should be fine. I'm not actually changing the docs, and the site is broken anyway!