-
Notifications
You must be signed in to change notification settings - Fork 65
WIP: [DO NOT MERGE] fix docs site publishing #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| push: | ||
| branches: | ||
| - main | ||
| - fix-publishing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publishing from this branch should be fine. I'm not actually changing the docs, and the site is broken anyway!
| ARGS="--prod" | ||
| fi | ||
| netlify deploy "$ARGS" \ | ||
| netlify deploy \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked for the available flags like this:
docker run \
--rm \
-it node:lts-alpine3.23 \
sh
npm install --global --force @aschmidt8/netlify-cli
netlify deploy --helpHopefully getting more logs will help us here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing some interesting things in the debug logs (logs link).
siteId: ***
› Error: Failed retrieving addons for site ***: Not Found. Double-check your login status with 'netlify status' or contact support with details of your error.
› Warning: Failed to resolve config, falling back to offline resolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next I looked into the configuration for the site:
docs/.github/workflows/deploy.yaml
Lines 53 to 54 in 31497b6
| NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_API_TOKEN }} | |
| NETLIFY_SITE_ID: ${{ secrets.NETLIFY_DOCS_SITE_ID }} |
Updated NETLIFY_SITE_ID to the value I see in the project configuration (https://app.netlify.com/projects/docs-rapids-ai/configuration/general), that did not fix anything.
Then updated NETLIFY_AUTH_TOKEN to a newly-generated token and that worked!
https://github.com/rapidsai/docs/actions/runs/21077092892/job/60621594737
Confirmed in this new build on main: https://github.com/rapidsai/docs/actions/runs/21077222946
✅ Deploy Preview for docs-rapids-ai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The fix was updating a token, no code changes required, closing this and deleting the branch. |
Trying to fix publishing, which has been broken like this since December 22:
(build link)
Notes for Reviewers
If you see this message, this isn't ready for review. Opening to test.