RDK-60308-[tr69hostif, RFC] RDK Coverity Defect Resolution for Device Management #158

Vismalskumar0 · 2026-01-23T05:06:38Z

RDK-60308-[tr69hostif, RFC] RDK Coverity Defect Resolution for Device Management

Copilot

Pull request overview

This PR addresses Coverity defects in the Device Management component by fixing memory leaks, adding move semantics optimizations, and improving code quality.

Changes:

Added proper cleanup of nested pointers in hashData structure to fix memory leaks
Introduced std::move() optimizations to reduce string copying overhead
Added default case to switch statement for better code coverage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-23T05:10:53Z

rfcMgr/rfc_xconf_handler.cpp

+				     break;
+			    default
+				     break;


Inconsistent indentation: These lines use tabs while surrounding code uses spaces. Consider maintaining consistent indentation style throughout the file.

rfcMgr/rfc_xconf_handler.cpp

Copilot · 2026-01-23T05:10:55Z

rfcMgr/rfc_xconf_handler.cpp

+				if(file_dwnl.hashData->hashvalue != nullptr)
+                {
+                    free(file_dwnl.hashData->hashvalue);
+                    file_dwnl.hashData->hashvalue = nullptr;
+                }
+                if(file_dwnl.hashData->hashtime != nullptr)
+                {
+                    free(file_dwnl.hashData->hashtime);
+                    file_dwnl.hashData->hashtime = nullptr;
+                }
                free(file_dwnl.hashData);
+				file_dwnl.hashData = nullptr;


Inconsistent indentation: These lines use tabs while surrounding code uses spaces. Consider maintaining consistent indentation style throughout the file.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-01-23T05:17:39Z

@Vismalskumar0 I've opened a new pull request, #159, to work on those changes. Once the pull request is ready, I'll request review from you.

rfcMgr/rfc_xconf_handler.cpp

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_xconf_handler.cpp

Copilot · 2026-01-23T05:27:34Z

rfcMgr/rfc_xconf_handler.cpp

+	RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Value: %s\n", __FUNCTION__,__LINE__,ClearDB.c_str());
+    set_RFCProperty(name, std::move(ClearDB), clearValue);
    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Bootstrap Clearing DB Value: %s\n", __FUNCTION__,__LINE__,BootstrapClearDB.c_str());
+    set_RFCProperty(name, std::move(BootstrapClearDB), clearValue);


Use-after-move error: The BootstrapClearDB string is logged at line 1300 using .c_str(), but then immediately moved at line 1301. After std::move(), BootstrapClearDB is in an unspecified state and using it is undefined behavior. The logging should occur after the set_RFCProperty call, or the second parameter should not use std::move() since it's still needed by the logging statement.

Suggested change

set_RFCProperty(name, std::move(BootstrapClearDB), clearValue);

set_RFCProperty(name, BootstrapClearDB, clearValue);

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-01-23T05:33:24Z

rfcMgr/rfc_xconf_handler.cpp

    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Bootstrap Clearing DB Value: %s\n", __FUNCTION__,__LINE__,BootstrapClearDB.c_str());
+    set_RFCProperty(name, BootstrapClearDB, clearValue);
    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] ConfigChangeTime: %s\n", __FUNCTION__,__LINE__,ConfigChangeTime.c_str());
+    set_RFCProperty(name, ConfigChangeTimeKey, ConfigChangeTime);


Coverity Issue - Variable copied when it could be moved

"ConfigChangeTime" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""ConfigChangeTime"")" instead of "ConfigChangeTime".

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_xconf_handler.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-23T05:37:20Z

rfcMgr/rfc_xconf_handler.cpp

    std::string ConfigSetHashName = "ConfigSetHash";
    std::string ConfigSetHash_key = "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Control.ConfigSetHash";
-    set_RFCProperty(ConfigSetHashName, ConfigSetHash_key, configSetHash);
+    set_RFCProperty(std::move(ConfigSetHashName), std::move(ConfigSetHash_key), configSetHash);


Unnecessary use of std::move on local variables that are only used once. The function signature set_RFCProperty(std::string name, std::string key, std::string value) takes all parameters by value, which means they will be copied regardless of std::move. Since ConfigSetHashName and ConfigSetHash_key are local variables that are not used after this call, the compiler's copy elision and move semantics will automatically optimize this. Using std::move here doesn't provide any benefit and makes the code less readable.

Suggested change

set_RFCProperty(std::move(ConfigSetHashName), std::move(ConfigSetHash_key), configSetHash);

set_RFCProperty(ConfigSetHashName, ConfigSetHash_key, configSetHash);

Copilot · 2026-01-23T05:37:21Z

rfcMgr/rfc_xconf_handler.cpp

    std::string ConfigSetTimeName = "ConfigSetTime";
    std::string ConfigSetTime_Key = "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Control.ConfigSetTime";
-    set_RFCProperty(ConfigSetTimeName, ConfigSetTime_Key, timestampString);
+    set_RFCProperty(std::move(ConfigSetTimeName), std::move(ConfigSetTime_Key), timestampString);


Unnecessary use of std::move on local variables that are only used once. The function signature set_RFCProperty(std::string name, std::string key, std::string value) takes all parameters by value, which means they will be copied regardless of std::move. Since ConfigSetTimeName and ConfigSetTime_Key are local variables that are not used after this call, the compiler's copy elision and move semantics will automatically optimize this. Using std::move here doesn't provide any benefit and makes the code less readable.

Copilot · 2026-01-23T05:37:21Z

rfcMgr/rfc_xconf_handler.cpp

+				if(file_dwnl.hashData->hashvalue != nullptr)
+                {
+                    free(file_dwnl.hashData->hashvalue);
+                    file_dwnl.hashData->hashvalue = nullptr;
+                }
+                if(file_dwnl.hashData->hashtime != nullptr)
+                {
+                    free(file_dwnl.hashData->hashtime);
+                    file_dwnl.hashData->hashtime = nullptr;
+                }
                free(file_dwnl.hashData);
+				file_dwnl.hashData = nullptr;


Inconsistent indentation: Lines 1990, 1993, and 2001 use tabs while surrounding code uses spaces. This violates the consistent indentation pattern seen throughout the file. Consider maintaining consistent indentation style (appears to be 4 spaces based on surrounding context).

rdkcmf-jenkins · 2026-01-23T05:40:43Z

rfcMgr/rfc_xconf_handler.cpp

    touch_file.close();	

+	RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Value: %s\n", __FUNCTION__,__LINE__,ClearDB.c_str());
    set_RFCProperty(name, ClearDB, clearValue);


Coverity Issue - Variable copied when it could be moved

"ClearDB" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""ClearDB"")" instead of "ClearDB".

rdkcmf-jenkins · 2026-01-23T05:40:43Z

rfcMgr/rfc_xconf_handler.cpp

-
-    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Value: %s\n", __FUNCTION__,__LINE__,ClearDB.c_str());
    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Bootstrap Clearing DB Value: %s\n", __FUNCTION__,__LINE__,BootstrapClearDB.c_str());
+    set_RFCProperty(name, BootstrapClearDB, clearValue);


Coverity Issue - Variable copied when it could be moved

"BootstrapClearDB" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""BootstrapClearDB"")" instead of "BootstrapClearDB".

rdkcmf-jenkins · 2026-01-23T05:40:43Z

rfcMgr/rfc_xconf_handler.cpp

    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Reload Cache Key: %s\n", __FUNCTION__,__LINE__,reloadCacheKey.c_str());
+    set_RFCProperty(name, ClearDBEndKey, clearValue);
+    set_RFCProperty(name, BootstrapClearDBEndKey, clearValue);
+    set_RFCProperty(name, reloadCacheKey, clearValue);


Coverity Issue - Variable copied when it could be moved

"reloadCacheKey" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""reloadCacheKey"")" instead of "reloadCacheKey".

rdkcmf-jenkins · 2026-01-23T05:40:43Z

rfcMgr/rfc_xconf_handler.cpp

    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DBEnd Key Value: %s\n", __FUNCTION__,__LINE__,ClearDBEndKey.c_str());
    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Bootstrap Clearing DBEnd Key Value: %s\n", __FUNCTION__,__LINE__,BootstrapClearDBEndKey.c_str());
    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Reload Cache Key: %s\n", __FUNCTION__,__LINE__,reloadCacheKey.c_str());
+    set_RFCProperty(name, ClearDBEndKey, clearValue);


Coverity Issue - Variable copied when it could be moved

"ClearDBEndKey" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""ClearDBEndKey"")" instead of "ClearDBEndKey".

rdkcmf-jenkins · 2026-01-23T05:40:43Z

rfcMgr/rfc_xconf_handler.cpp

    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Bootstrap Clearing DBEnd Key Value: %s\n", __FUNCTION__,__LINE__,BootstrapClearDBEndKey.c_str());
    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Reload Cache Key: %s\n", __FUNCTION__,__LINE__,reloadCacheKey.c_str());
+    set_RFCProperty(name, ClearDBEndKey, clearValue);
+    set_RFCProperty(name, BootstrapClearDBEndKey, clearValue);


Coverity Issue - Variable copied when it could be moved

"BootstrapClearDBEndKey" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""BootstrapClearDBEndKey"")" instead of "BootstrapClearDBEndKey".

nhanasi · 2026-01-23T19:46:50Z

@Vismalskumar0 -please fix the coverity failures and share the Dev test lgos

Copilot · 2026-01-27T08:32:16Z

@Vismalskumar0 I've opened a new pull request, #160, to work on those changes. Once the pull request is ready, I'll request review from you.

Vismalskumar0 added 2 commits January 23, 2026 09:38

Move instead of copy

3d10f07

Update rfc_xconf_handler.cpp

3d9ee80

Vismalskumar0 requested a review from a team as a code owner January 23, 2026 05:06

Copilot AI review requested due to automatic review settings January 23, 2026 05:06

Copilot started reviewing on behalf of Vismalskumar0 January 23, 2026 05:06 View session

Update rfc_xconf_handler.cpp

ac48d81

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Update rfc_xconf_handler.cpp

00ef0b0

Copilot AI mentioned this pull request Jan 23, 2026

Fix tab/space indentation inconsistencies in rfc_xconf_handler.cpp #159

Draft

rdkcmf-jenkins reviewed Jan 23, 2026

View reviewed changes

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

rdkcmf-jenkins reviewed Jan 23, 2026

View reviewed changes

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

Update rfc_xconf_handler.cpp

c88863b

Copilot AI review requested due to automatic review settings January 23, 2026 05:24

Copilot started reviewing on behalf of Vismalskumar0 January 23, 2026 05:25 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Update rfcMgr/rfc_xconf_handler.cpp

a292ffd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 23, 2026 05:27

Copilot started reviewing on behalf of Vismalskumar0 January 23, 2026 05:28 View session

Vismalskumar0 and others added 3 commits January 23, 2026 11:00

Update rfcMgr/rfc_xconf_handler.cpp

87e20be

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update rfcMgr/rfc_xconf_handler.cpp

c4ee59b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update rfcMgr/rfc_xconf_handler.cpp

7c5dcbc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins reviewed Jan 23, 2026

View reviewed changes

Update rfcMgr/rfc_xconf_handler.cpp

59325ac

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Jan 23, 2026

View reviewed changes

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

Update rfcMgr/rfc_xconf_handler.cpp

f647fec

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 23, 2026 05:34

Copilot started reviewing on behalf of Vismalskumar0 January 23, 2026 05:34 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

rdkcmf-jenkins reviewed Jan 23, 2026

View reviewed changes

nhanasi approved these changes Jan 23, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 27, 2026

Fix inconsistent indentation in rfc_xconf_handler.cpp #160

Draft

	set_RFCProperty(name, std::move(BootstrapClearDB), clearValue);
	set_RFCProperty(name, BootstrapClearDB, clearValue);

	set_RFCProperty(std::move(ConfigSetHashName), std::move(ConfigSetHash_key), configSetHash);
	set_RFCProperty(ConfigSetHashName, ConfigSetHash_key, configSetHash);

RDK-60308-[tr69hostif, RFC] RDK Coverity Defect Resolution for Device Management #158

Are you sure you want to change the base?

RDK-60308-[tr69hostif, RFC] RDK Coverity Defect Resolution for Device Management #158

Uh oh!

Conversation

Vismalskumar0 commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Vismalskumar0 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Jan 23, 2026

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Jan 23, 2026

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Jan 23, 2026

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Jan 23, 2026

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!