Skip to content

Conversation

Copy link

Copilot AI commented Jan 27, 2026

Addresses feedback on PR #158 regarding mixed tabs/spaces in the hashData cleanup block.

Changes

  • Replaced tabs with spaces on lines 1990 and 2001 in rfcMgr/rfc_xconf_handler.cpp
  • Ensures consistent 16-space indentation matching surrounding code
// Before: tabs (inconsistent)
if(file_dwnl.hashData != nullptr)
{
    if(file_dwnl.hashData->hashvalue != nullptr)  // ← tabs here
    
    file_dwnl.hashData = nullptr;                 // ← and here
}

// After: spaces (consistent)
if(file_dwnl.hashData != nullptr)
{
    if(file_dwnl.hashData->hashvalue != nullptr)  // ← spaces now
    
    file_dwnl.hashData = nullptr;                 // ← spaces now
}

This PR merges into #158 as a stacked PR to address the specific code review feedback.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…2001

Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Addressing feedback on RDK Coverity defect resolution Fix inconsistent indentation in rfc_xconf_handler.cpp Jan 27, 2026
Copilot AI requested a review from Vismalskumar0 January 27, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants