Update ZenFS #40
Closed
Update ZenFS #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niedzielski
suggested changes
Nov 1, 2024
Contributor
niedzielski
left a comment
niedzielski
left a comment
There was a problem hiding this comment.
thank you so much, @james-pre! I left a little feedback inline 👍 basic editor smoketest looks good but I'm flagging @ObsidianSnoo to check the asset functionality.
Author
|
Just FYI, |
ObsidianSnoo
added a commit
that referenced
this pull request
Jan 6, 2025
<!-- If this pull request closes an issue, please mention the issue number below --> Closes # <!-- Issue # here --> ## 💸 TL;DR <!-- What's the three sentence summary of purpose of the PR --> Migrates the unsupported dependency, follow up for #40 ## 📜 Details [Design Doc](<!-- insert Google Doc link here if applicable -->) [Jira](<!-- insert Jira link if applicable -->) <!-- Add additional details required for the PR: breaking changes, screenshots, external dependency changes --> ## 🧪 Testing Steps / Validation <!-- add details on how this PR has been tested, include reproductions and screenshots where applicable --> ## ✅ Checks <!-- Make sure your pr passes the CI checks and do check the following fields as needed - --> - [x] CI tests (if present) are passing - [x] Adheres to code style for repo - [ ] Contributor License Agreement (CLA) completed if not a Reddit employee --------- Co-authored-by: danil.radkovskyi <danil.radkovskyi@reddit.com> Co-authored-by: ObsidianSnoo <66971815+ObsidianSnoo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
@zenfs/coreand@zenfs/domto stable versions (i.e.^1.0.0) and updates@zenfs/zipto the latest minor release (^0.5.0).