-
Notifications
You must be signed in to change notification settings - Fork 34
[chore] Updating orchestrator npm packages to OCI artifacts #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[chore] Updating orchestrator npm packages to OCI artifacts #2231
Conversation
Signed-off-by: Leanne Ahern <lahern@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
| plugins: | ||
| - disabled: true | ||
| package: "@redhat/backstage-plugin-orchestrator@1.8.2" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.1.0!red-hat-developer-hub-backstage-plugin-orchestrator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use just oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.1.0 here and later if it is a single artifact in oci image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, now that we have fixed the downstream issue with discovering the path from the annotation, you can safely use this for ghcr.io (community builds, not for GA use) AND quay.io (CI builds).
Ideally you would have the registry.access.redhat.com/rhdh/ path here, instead of either community or CI builds.
But then your install process needs a "can't find plugin on reg.acc.rh.com (because not GA yet) so fall back to quay.io/rhdh via mirror / IDMS" bit of mapping logic
So... maybe for THIS repo you use quay, and for downstream we transform from quay.io to/rhdh/ to registry.access.redhat.com/rhdh/ ?
| - disabled: true | ||
| package: "@redhat/backstage-plugin-orchestrator@1.8.2" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.1.0!red-hat-developer-hub-backstage-plugin-orchestrator" | ||
| integrity: sha512-rnUA6iZ2JVAyASfwS4P9HeFmpqCgH6FQouzzg4s6lCPAsYUFvu6tifJ3df5lThXPUTJ2cDvvQgamU+4DiHP2jw== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| integrity: sha512-rnUA6iZ2JVAyASfwS4P9HeFmpqCgH6FQouzzg4s6lCPAsYUFvu6tifJ3df5lThXPUTJ2cDvvQgamU+4DiHP2jw== |
You can remove the integrity line when using OCI references as it is not used for OCI references: https://github.com/redhat-developer/rhdh/blob/main/docker/install-dynamic-plugins.py#L54
Using a digest instead of tag allows performing an integrity check for OCI packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as noted above we probably want to use the downstream Konflux builds, not the ghcr.io community builds.
thought more about this and realized we need to do more transformation work to make this happen -- see https://issues.redhat.com/browse/RHIDP-11725
| - disabled: true | ||
| package: "@redhat/backstage-plugin-orchestrator-backend-dynamic@1.8.2" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator-backend:bs_1.45.3__8.3.0!red-hat-developer-hub-backstage-plugin-orchestrator-backend" | ||
| integrity: sha512-6G0YguzCM5nCDpOrIGJpLTXVMr6EBdIVqSXtsLH9RvBH25RTuFpfJ7q6eEp26DqveaiqUCfBpJ51smdjcsEzFQ== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| integrity: sha512-6G0YguzCM5nCDpOrIGJpLTXVMr6EBdIVqSXtsLH9RvBH25RTuFpfJ7q6eEp26DqveaiqUCfBpJ51smdjcsEzFQ== |
| - disabled: true | ||
| package: "@redhat/backstage-plugin-scaffolder-backend-module-orchestrator-dynamic@1.8.2" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scaffolder-backend-module-orchestrator:bs_1.45.3__1.3.1!red-hat-developer-hub-backstage-plugin-scaffolder-backend-module-orchestrator" | ||
| integrity: sha512-N2hCn9RI/QVEoK56FAkGkSDbvfQCOIzVsJTwDX0kf//npO++2crRSJpB1Lr/m2UtYxfaXZX53p8sPcK3g8yWkQ== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| integrity: sha512-N2hCn9RI/QVEoK56FAkGkSDbvfQCOIzVsJTwDX0kf//npO++2crRSJpB1Lr/m2UtYxfaXZX53p8sPcK3g8yWkQ== |
| - disabled: true | ||
| package: "@redhat/backstage-plugin-orchestrator-form-widgets@1.8.2" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets:bs_1.45.3__1.2.0!red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets" | ||
| integrity: sha512-Pe0dn3g+YTK3jbl36E8nt4zdyH/3w+MWgRyFWPc2B0eV4/L/aRfRC4KxcktmHPdamRGXTIaXL6cFae8TZl8Htw== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| integrity: sha512-Pe0dn3g+YTK3jbl36E8nt4zdyH/3w+MWgRyFWPc2B0eV4/L/aRfRC4KxcktmHPdamRGXTIaXL6cFae8TZl8Htw== |
|
/cherry-pick release-1.9 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| url: http://sonataflow-platform-data-index-service | ||
| - disabled: true | ||
| package: "@redhat/backstage-plugin-orchestrator-form-widgets@1.8.2" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets:bs_1.45.3__1.2.0!red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is a newer tag under bs_1.45.3. See redhat-developer/rhdh-chart#307 (comment)
| - ref: sonataflow | ||
| - disabled: true | ||
| package: "@redhat/backstage-plugin-scaffolder-backend-module-orchestrator-dynamic@1.8.2" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scaffolder-backend-module-orchestrator:bs_1.45.3__1.3.1!red-hat-developer-hub-backstage-plugin-scaffolder-backend-module-orchestrator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New tag available. See redhat-developer/rhdh-chart#307 (comment)
| plugins: | ||
| - disabled: true | ||
| package: "@redhat/backstage-plugin-orchestrator@1.8.2" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.1.0!red-hat-developer-hub-backstage-plugin-orchestrator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New tag available. See redhat-developer/rhdh-chart#307 (comment)
| - IsOrchestratorCatalogTabAvailable | ||
| - disabled: true | ||
| package: "@redhat/backstage-plugin-orchestrator-backend-dynamic@1.8.2" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator-backend:bs_1.45.3__8.3.0!red-hat-developer-hub-backstage-plugin-orchestrator-backend" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New tag available. See redhat-developer/rhdh-chart#307 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment in the Helm Chart about leveraging the {{inherit}} option introduced in 1.9.0: redhat-developer/rhdh-chart#307 (comment)
This is also applicable to the Operator and would make the config much simpler IMO.
If we use quay refs here instead, you can't cherry pick because the plugins will be using different tags (1.9.0-- or 1.10.0--) and therefore also different digests. |



Description
Updating orchestrator npm packages to the relevant OCI Artifacts to reflect updates to RHDH.
npm packages were causing the scaffolder plugin to throw an error during startup
Which issue(s) does this PR fix or relate to
RHDHBUGS-2527
PR acceptance criteria
How to test changes / Special notes to the reviewer
Deploy Operator-based instance of RHDH with the orchestrator plugins enabled.