Skip to content

chore(workflows/release): add Yarn 4 guard for publish step #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hopehadfield merged 1 commit into from
Jan 27, 2026
+12 −2
Merged

chore(workflows/release): add Yarn 4 guard for publish step #2150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/release_workspace.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,12 @@ jobs:
- name: publish
run: |
yarn config set -H 'npmAuthToken' "${{ secrets.RHDH_NPM_TOKEN }}"
yarn workspaces foreach -v --no-private npm publish --access public --tolerate-republish
YARN_VERSION="$(yarn --version)"
Copy link

@testcara testcara Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: How about create one reusable step or function for this?

Copy link
Contributor Author

@rrosatti rrosatti Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a nice idea! but I was thinking that it would be better to make minimal changes in this PR. Especially because I'm touching the release workflow files :)

if [[ "$YARN_VERSION" == 4.* ]]; then
yarn workspaces foreach -A -v --no-private npm publish --access public --tolerate-republish
else
yarn workspaces foreach -v --no-private npm publish --access public --tolerate-republish
fi
env:
NODE_AUTH_TOKEN: ${{ secrets.RHDH_NPM_TOKEN }}

Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/release_workspace_version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,12 @@ jobs:
- name: publish
run: |
yarn config set -H 'npmAuthToken' "$NODE_AUTH_TOKEN"
yarn workspaces foreach -v --no-private npm publish --access public --tolerate-republish --tag "maintenance"
YARN_VERSION="$(yarn --version)"
if [[ "$YARN_VERSION" == 4.* ]]; then
yarn workspaces foreach -A -v --no-private npm publish --access public --tolerate-republish --tag "maintenance"
else
yarn workspaces foreach -v --no-private npm publish --access public --tolerate-republish --tag "maintenance"
fi
env:
NODE_AUTH_TOKEN: ${{ secrets.RHDH_NPM_TOKEN }}

Expand Down