-
Notifications
You must be signed in to change notification settings - Fork 214
fix(pluginIDProvider): fix pluginIds for backstage-plugin- prefixed plugin names
#4071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pluginIDProvider): fix pluginIds for backstage-plugin- prefixed plugin names
#4071
Conversation
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
|
The image is available at: |
|
/retest |
|
The image is available at: |
|
Tested the PR on a cluster: Screen.Recording.2026-01-27.at.16.41.09.mov |
|
/retest |
|
@dzemanov not certain why this is happening on your PR and wasn't prior, but I believe that the |
|
|
The image is available at: |
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrienkoAleksandr, djanickova, polasudo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.9 |
|
@dzemanov: new pull request created: #4090 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |



Description
Plugins from rhdh-plugins have ids starting with
backstage-plugin, example 1 or 2. Regex for creating plugin ids from plugin names was not capturing this case, so all our rhdh-plugins that are not wrappers had invalid pluginIds created.For example for scorecard:
results in this error:
should be calling this endpoint:
Which issue(s) does this PR fix
Demo
pluginProvider.mov
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer