Skip to content

Conversation

@dzemanov
Copy link
Member

Description

  • updates regex to handle backstage-plugin prefixed rhdh-plugins

Plugins from rhdh-plugins have ids starting with backstage-plugin, example 1 or 2. Regex for creating plugin ids from plugin names was not capturing this case, so all our rhdh-plugins that are not wrappers had invalid pluginIds created.

For example for scorecard:

name: @red-hat-developer-hub/backstage-plugin-scorecard-backend-dynamic
after cleanup: @red-hat-developer-hub/backstage-plugin-scorecard

results in this error:

2026-01-27T11:16:17.776Z permission warn No permission metadata found for @red-hat-developer-hub/backstage-plugin-scorecard. NotFoundError: could not read http://localhost:7007/api/%40red-hat-developer-hub%2Fbackstage-plugin-scorecard/.well-known/backstage/permissions/metadata, 404 Not Found 

should be calling this endpoint:

api/scorecard/.well-known/backstage/permissions/metadata

Which issue(s) does this PR fix

Demo

pluginProvider.mov

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
@github-actions
Copy link
Contributor

@dzemanov
Copy link
Member Author

/retest

@github-actions
Copy link
Contributor

@dzemanov
Copy link
Member Author

Tested the PR on a cluster:

Screen.Recording.2026-01-27.at.16.41.09.mov

@dzemanov
Copy link
Member Author

/retest

@PatAKnight
Copy link
Member

@dzemanov not certain why this is happening on your PR and wasn't prior, but I believe that the Verify theme colors are applied and make screenshots test that is failing is happening because the quickstart menu is open and in the way. Just opened up a bug report for it: https://issues.redhat.com/browse/RHDHBUGS-2555

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

@djanickova
Copy link
Member

/approve
/lgtm

@polasudo
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrienkoAleksandr, djanickova, polasudo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dzemanov dzemanov merged commit 5667b0d into redhat-developer:main Jan 28, 2026
19 checks passed
@dzemanov
Copy link
Member Author

/cherry-pick release-1.9

@openshift-cherrypick-robot
Copy link
Contributor

@dzemanov: new pull request created: #4090

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants