Remove remote for re-creating it if url has changed #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evallesp
added a commit
to evallesp/patch_rebaser
that referenced
this pull request
Mar 14, 2025
Previously we were checking if the remote name is there to add it. Now, if the patches_repo url has changed, but we maintain the same remote_name, this is updated. For doing this, we just check if the remote_name exists and if the patches_repo differs from its value. If so, we just remove the remote so next line below it'd recreate it. Not it's based on new git_wrapper version that allows to return the remote dict with its value but also to remove the remote. Requires: release-depot/git_wrapper#114
jguiditta
reviewed
Mar 18, 2025
Member
jguiditta
left a comment
jguiditta
left a comment
There was a problem hiding this comment.
Couple minor things, otherwise seems reasonable
eggmaster
reviewed
Mar 18, 2025
eggmaster
left a comment
eggmaster
left a comment
There was a problem hiding this comment.
couple comments in addition/response to jguiditta's, but this looks good to me otherwise!
evallesp
added a commit
to evallesp/patch_rebaser
that referenced
this pull request
Mar 24, 2025
Previously we were checking if the remote name is there to add it. Now, if the patches_repo url has changed, but we maintain the same remote_name, this is updated. For doing this, we just check if the remote_name exists and if the patches_repo differs from its value. If so, we just remove the remote so next line below it'd recreate it. Not it's based on new git_wrapper version that allows to return the remote dict with its value but also to remove the remote. Requires: release-depot/git_wrapper#114
evallesp
force-pushed
the
add-remove-remote
branch
from
7415ca0 to
e05895a
Compare
evallesp
commented
Mar 24, 2025
evallesp
force-pushed
the
add-remove-remote
branch
from
e05895a to
1a33779
Compare
eggmaster
previously approved these changes
Mar 24, 2025
jguiditta
reviewed
Mar 24, 2025
Member
jguiditta
left a comment
jguiditta
left a comment
There was a problem hiding this comment.
One question, otherwise, I think this is good!
We're adding the possibility to remove the remote. This, with the addition of names_url_dict, makes the posibility of checking the remote url, and if it's updated, then remove it for re-creating.
evallesp
force-pushed
the
add-remove-remote
branch
from
1a33779 to
3a24f99
Compare
evallesp
added a commit
to evallesp/patch_rebaser
that referenced
this pull request
Mar 25, 2025
Previously we were checking if the remote name is there to add it. Now, if the patches_repo url has changed, but we maintain the same remote_name, this is updated. For doing this, we just check if the remote_name exists and if the patches_repo differs from its value. If so, we just remove the remote so next line below it'd recreate it. Not it's based on new git_wrapper version that allows to return the remote dict with its value but also to remove the remote. Requires: release-depot/git_wrapper#114
jguiditta
approved these changes
Mar 25, 2025
eggmaster
approved these changes
Mar 25, 2025
evallesp
added a commit
to evallesp/patch_rebaser
that referenced
this pull request
Mar 25, 2025
Previously we were checking if the remote name is there to add it. Now, if the patches_repo url has changed, but we maintain the same remote_name, this is updated. For doing this, we just check if the remote_name exists and if the patches_repo differs from its value. If so, we just remove the remote so next line below it'd recreate it. Not it's based on new git_wrapper version that allows to return the remote dict with its value but also to remove the remote. Requires: release-depot/git_wrapper#114
evallesp
added a commit
to evallesp/patch_rebaser
that referenced
this pull request
Mar 25, 2025
Previously we were checking if the remote name is there to add it. Now, if the patches_repo url has changed, but we maintain the same remote_name, this is updated. For doing this, we just check if the remote_name exists and if the patches_repo differs from its value. If so, we just remove the remote so next line below it'd recreate it. Not it's based on new git_wrapper version that allows to return the remote dict with its value but also to remove the remote. Requires: release-depot/git_wrapper#114
eggmaster
pushed a commit
to release-depot/patch_rebaser
that referenced
this pull request
Apr 2, 2025
Previously we were checking if the remote name is there to add it. Now, if the patches_repo url has changed, but we maintain the same remote_name, this is updated. For doing this, we just check if the remote_name exists and if the patches_repo differs from its value. If so, we just remove the remote so next line below it'd recreate it. Not it's based on new git_wrapper version that allows to return the remote dict with its value but also to remove the remote. Requires: release-depot/git_wrapper#114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding the possibility to remove the remote. This, with the addition of names_url_dict, makes the posibility of checking the remote url, and if it's updated, then remove it for re-creating.