Skip to content

[WIP] Fix cob #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hsd-dev wants to merge 22 commits into from
Closed

[WIP] Fix cob #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
40f2632
converted to arrays
hsd-dev Aug 5, 2020
7560f61
[WIP] fixes issues with the json schema
hsd-dev Sep 9, 2020
009c275
porting schema to yamale
hsd-dev Sep 9, 2020
64e518e
update validator and bug
hsd-dev Sep 9, 2020
9e9be82
validate links
hsd-dev Oct 7, 2020
5e90d4e
include for hash
hsd-dev Oct 7, 2020
3926648
use yamale in validate.sh
hsd-dev Oct 7, 2020
a31a18a
converted to arrays
hsd-dev Aug 5, 2020
3ea5fcf
[WIP] fixes issues with the json schema
hsd-dev Sep 9, 2020
ff57aa7
porting schema to yamale
hsd-dev Sep 9, 2020
bded623
update validator and bug
hsd-dev Sep 9, 2020
2119548
validate links
hsd-dev Oct 7, 2020
db21e4b
include for hash
hsd-dev Oct 7, 2020
e8853fc
use yamale in validate.sh
hsd-dev Oct 7, 2020
98e6bbc
test for parsing yaml
hsd-dev Oct 13, 2020
3726e5b
clean bug file
hsd-dev Oct 13, 2020
8493784
added fault and failure codes in schema
hsd-dev Oct 13, 2020
13a0c8d
fix conflict
hsd-dev Oct 13, 2020
56c54eb
converted time to Z-notation UTC timestamp
hsd-dev Oct 14, 2020
e715bf3
included locomotion in task schema
hsd-dev Oct 15, 2020
159c546
list formatting
hsd-dev Oct 18, 2020
bd8a8f5
fault and failure codes
hsd-dev Oct 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions care-o-bot/0000000/0000000.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,21 @@ description: >
"hardware_interface". This error could be fixed by updating the
outdated ROS packages.
classification: "Wrong behavior (no CWE) #EVOLUTION CWE-439 #PHYSICAL"
keywords: ['metapackage', 'package', 'update', 'outdated']
keywords:
- 'metapackage'
- 'package'
- 'update'
- 'outdated'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/Metapackages', 'https://github.com/ros-controls/ros_control']
links:
- 'http://wiki.ros.org/Metapackages'
- 'https://github.com/ros-controls/ros_control'
failure-codes:
- SYSTEM:UNINTENDED-BEHAVIOUR
fault-codes:
- EVOLUTION:PACKAGE
- ROS-SPECIFIC
bug:
phase: runtime
specificity: ROS-specific
Expand Down
18 changes: 15 additions & 3 deletions care-o-bot/105dc16/105dc16.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,22 @@ description: >
package name and thus, one can have a generic name, which is
independent of the package name.
classification: Missing Dependency (no CWE)
keywords: ['missing', 'dependencies', 'gencpp', 'project_name', 'CMakeLists']
keywords:
- 'missing'
- 'dependencies'
- 'gencpp'
- 'project_name'
- 'CMakeLists'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/catkin/CMakeLists.txt', 'http://wiki.ros.org/gencpp']
links:
- 'http://wiki.ros.org/catkin/CMakeLists.txt'
- 'http://wiki.ros.org/gencpp'
failure-codes:
- SOFTWARE:BUILD
fault-codes:
- BDO:BUILD
- BDO:DEPENDENCY
bug:
phase: build
specificity: ROS-specific
Expand All @@ -45,4 +57,4 @@ fix:
- cob_control/cob_twist_controller/CMakeLists.txt
languages:
- CMake
time: 2014-11-21 (12:57)
time: 2014-11-21T12:57:00Z
Copy link
Member

@gavanderhoorn gavanderhoorn Oct 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note again: unless the original time was already in UTC, this is not a valid conversion.

It's likely these times were reported in CET or CEST, which would make this +0200 (but this is just a guess).

Copy link
Contributor Author

@hsd-dev hsd-dev Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not worked on that. As I mentioned in the comment, I have worked only on fault and failure codes.

Copy link
Member

@gavanderhoorn gavanderhoorn Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand your comment: are you saying you didn't change these time entries?

What makes them show up in the diff here?

Copy link
Member

@gavanderhoorn gavanderhoorn Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR build on #359? See also #359 (comment), where I commented on 0c46707.

Copy link
Contributor Author

@hsd-dev hsd-dev Oct 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this PR is behind #359. I have not modified the time yet after your comment.

I have not worked on that.

Sorry about the confusion. I meant 'after your comment'.

Copy link
Member

@gavanderhoorn gavanderhoorn Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent we accidentally merge this, perhaps drop 0c46707 for now?

Copy link
Contributor Author

@hsd-dev hsd-dev Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to avoid the confusion and separate the concerns, I will remove 0c46707, so #359 is only about the script and the schema.

39 changes: 32 additions & 7 deletions care-o-bot/1518978/1518978.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,37 @@ description: >
but not if the path-name is defined globally. This could cause a
mismatch of names if not handled correctly.
classification: Use of Global Names (no CWE)
keywords: ['namespace', 'hardcoded', 'parameter', 'global']
keywords:
- 'namespace'
- 'hardcoded'
- 'parameter'
- 'global'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/Names', 'http://wiki.ros.org/roslaunch/XML/group']
links:
- 'http://wiki.ros.org/Names'
- 'http://wiki.ros.org/roslaunch/XML/group'
failure-codes:
- NONE
fault-codes:
- BAD-SMELL
- ROS-SPECIFIC
- CONFIG:NAMESPACE
bug:
phase: runtime
specificity: ROS-specific
architectural-location: application-specific
architectural-location: application-specific code
application: cob drivers
task: null
task: N/A
subsystem: driver
package: cob_drivers
package:
- cob_drivers
languages:
- C++
detected-by: developer
reported-by: member developer
issue: https://github.com/ipa320/cob_driver/issues/272
time-reported: 2016-04-07 (00:00)
time-reported: 2016-04-07T00:00:00Z
reproducibility: sometimes
trace: null
fix:
Expand All @@ -43,4 +56,16 @@ fix:
fix-in: ['https://github.com/ipa-fxm/cob_driver/blob/151897840540e8dd662cf6c8c77e5613c84e3424/cob_sound/ros/src/sound.cpp']
languages:
- C++
time: 2016-04-07 (00:00)
time: 2016-04-07T00:00:00Z
time-machine:
ros_distro:
ros_pkgs:
-
datetime:
bugzoo:
is-build-failure:
bug-commit:
fix-commit:
fork-urls:
-

15 changes: 11 additions & 4 deletions care-o-bot/28c23cd/28c23cd.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,21 @@ description: >
solved by adding "include_directories(${catkin_INCLUDE_DIRS})" to
the CMakeLists.
classification: Missing Include / Dependency (no CWE)
keywords: ['include directories', 'CMakeLists']
keywords:
- 'include directories'
- 'CMakeLists'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/catkin/CMakeLists.txt; 7.3']
links:
- 'http://wiki.ros.org/catkin/CMakeLists.txt; 7.3'
failure-codes:
- SOFTWARE:BUILD
fault-codes:
- BDO:BUILD
bug:
phase: build
specificity: ROS-specific
architectural-location: application-specific
architectural-location: application-specific code
application: N/A
task: N/A
subsystem: specific application component
Expand All @@ -44,4 +51,4 @@ fix:
- cob_command_tools/cob_teleop/CMakeLists.txt
languages:
- CMake
time: 2015-11-24 (19:36)
time: 2015-11-24T19:36:00Z
20 changes: 17 additions & 3 deletions care-o-bot/43705f7/43705f7.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,24 @@ description: >
real hardware. The problem is solved by introducing consistent
naming.
classification: inconsistent naming
keywords: ['xacro', 'gazebo', 'topic', 'name', 'inconsistency']
keywords:
- 'xacro'
- 'gazebo'
- 'topic'
- 'name'
- 'inconsistency'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/xacro', 'http://gazebosim.org/tutorials?tut=ros_gzplugins']
links:
- 'http://wiki.ros.org/xacro'
- 'http://gazebosim.org/tutorials?tut=ros_gzplugins'
failure-codes:
- SYSTEM:UNINTENDED-BEHAVIOUR
- SOFTWARE:SILENT
fault-codes:
- NAMING-TYPOS
- ROS-SPECIFIC
- CONFIG:TOPIC
bug:
phase: runtime
specificity: robotics-specific
Expand All @@ -42,4 +56,4 @@ fix:
fix-in: ['https://github.com/ipa320/cob_common/pull/179/commits/43705f74847ce09edb971adb50d9e47b14f944cf']
languages:
- xacro
time: 2015-11-20 (00:00)
time: 2015-11-20T00:00:00Z
13 changes: 10 additions & 3 deletions care-o-bot/79867c8/79867c8.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,17 @@ description: >
packages gets updated one has to update the install tragets
accordingly.
classification: "Missing Installation Dependencies (no CWE)"
keywords: ['install targets', 'CMakeLists']
keywords:
- 'install targets'
- 'CMakeLists'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/catkin/CMakeLists.txt; 11']
links:
- 'http://wiki.ros.org/catkin/CMakeLists.txt; 11'
failure-codes:
- SOFTWARE:BUILD
fault-codes:
- BDO:BUILD
bug:
phase: build
specificity: ROS-specific
Expand All @@ -51,4 +58,4 @@ fix:
- cob_android/cob_android_script_server/CMakeLists.txt
languages:
- CMake
time: 2015-08-04 (16:26)
time: 2015-08-04T16:26:00Z
17 changes: 14 additions & 3 deletions care-o-bot/ac6a181/ac6a181.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,21 @@ description: >
dependency to the package.xml with the line
<run_depend>ipython</run_depend>.
classification: Missing Dependency (no CWE)
keywords: ['missing', 'dependencies', 'library', 'package.xml']
keywords:
- 'missing'
- 'dependencies'
- 'library'
- 'package.xml'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/catkin/package.xml']
links:
- 'http://wiki.ros.org/catkin/package.xml'
failure-codes:
- SOFTWARE:RUNTIME
- SYSTEM:LIVENESS
fault-codes:
- BDO:DEPENDENCY
- BDO:ORCHESTRATION
bug:
phase: startup
specificity: ROS-specific
Expand All @@ -39,4 +50,4 @@ fix:
- cob_command_tools/cob_script_server/package.xml
languages:
- XML
time: 2014-08-26 (08:57)
time: 2014-08-26T08:57:00Z
19 changes: 16 additions & 3 deletions care-o-bot/b826eae/b826eae.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,23 @@ description: >
adding the newly introduced argument to the parent-xacro at the
respective call of the child-xacro.
classification: "CWE-685: Wrong Number of Function Arguments #EVOLUTION"
keywords: ['xacro', 'arguments', 'update', 'outdated']
keywords:
- 'xacro'
- 'arguments'
- 'update'
- 'outdated'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/xacro']
links:
- 'http://wiki.ros.org/xacro'
failure-codes:
- SOFTWARE:RUNTIME
- SYSTEM:LIVENESS
fault-codes:
- CONFIG:ARGS
- EVOLUTION:PACKAGE
- BDO:ORCHESTRATION
- PROGRAMMING:BROKEN-CONTRACT
bug:
phase: build
specificity: ROS-specific
Expand All @@ -44,4 +57,4 @@ fix:
fix-in: ['https://github.com/ipa-fmw/cob_robots/blob/b826eaeae5c8dc548ac2c97002725c7a8131137e/cob_hardware_config/cob3-9/urdf/cob3-9.urdf.xacro']
languages:
- xacro
time: 2016-11-10 (00:00)
time: 2016-11-10T00:00:00Z
16 changes: 13 additions & 3 deletions care-o-bot/c8091b6/c8091b6.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,20 @@ description: >
library, since it was not required anymore. Otherwise, one would
have needed to add the dependency to the package.xml.
classification: Missing Dependency (no CWE)
keywords: ['missing', 'dependencies', 'library', 'package.xml']
keywords:
- 'missing'
- 'dependencies'
- 'library'
- 'package.xml'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/catkin/package.xml']
links:
- 'http://wiki.ros.org/catkin/package.xml'
failure-codes:
- SOFTWARE:RUNTIME
fault-codes:
- ROS-SPECIFIC
- BDO:DEPENDENCY
bug:
phase: startup
specificity: ROS-specific
Expand All @@ -40,4 +50,4 @@ fix:
- cob_command_tools/cob_command_gui/src/knoeppkes.py
languages:
- Python
time: 2015-03-13 (16:21)
time: 2015-03-13T16:21:00Z
18 changes: 15 additions & 3 deletions care-o-bot/ca7b536/ca7b536.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,22 @@ description: >
package name and thus, one can have a generic name, which is
independent of the package name.
classification: Missing Dependency (no CWE)
keywords: ['missing', 'dependencies', 'gencpp', 'project_name', 'CMakeLists']
keywords:
- 'missing'
- 'dependencies'
- 'gencpp'
- 'project_name'
- 'CMakeLists'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/catkin/CMakeLists.txt', 'http://wiki.ros.org/gencpp']
links:
- 'http://wiki.ros.org/catkin/CMakeLists.txt'
- 'http://wiki.ros.org/gencpp'
failure-codes:
- SOFTWARE:BUILD
fault-codes:
- BDO:BUILD
- BDO:DEPENDENCY
bug:
phase: build
specificity: ROS-specific
Expand All @@ -46,4 +58,4 @@ fix:
- cob_control/cob_obstacle_distance/CMakeLists.txt
languages:
- CMake
time: 2015-08-04 (13:09)
time: 2015-08-04T13:09:00Z
22 changes: 18 additions & 4 deletions care-o-bot/e9ed0f8/e9ed0f8.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,22 @@ description: >
...and to CMakeList with the lines:
catkin_package(... joint_limits_interface ...).
classification: Missing Dependency (no CWE)
keywords: ['missing', 'dependencies', 'library', 'package.xml', 'CMakeList']
keywords:
- 'missing'
- 'dependencies'
- 'library'
- 'package.xml'
- 'CMakeList'
system: care-o-bot
severity: error
links: ['http://wiki.ros.org/catkin/package.xml', 'http://wiki.ros.org/catkin/CMakeLists.txt']
links:
- 'http://wiki.ros.org/catkin/package.xml'
- 'http://wiki.ros.org/catkin/CMakeLists.txt'
failure-codes:
- SOFTWARE:BUILD
fault-codes:
- BDO:DEPENDENCY
- BDO:ORCHESTRATION
bug:
phase: build
specificity: ROS-specific
Expand All @@ -43,8 +55,10 @@ fix:
hash: e9ed0f8e157398621987bd61e2d78683cd945c2b
pull-request: https://github.com/ros-simulation/gazebo_ros_pkgs/pull/343
license: ['LGPL']
fix-in: ['gazebo_ros_control/CMakeLists.txt', 'gazebo_ros_control/package.xml']
fix-in:
- 'gazebo_ros_control/CMakeLists.txt'
- 'gazebo_ros_control/package.xml'
languages:
- CMake
- XML
time: 2015-08-08 (10:05)
time: 2015-08-08T10:05:00Z
2 changes: 1 addition & 1 deletion confidential/2688e7a/2688e7a.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ fix:
fix-in: ['CONFIDENTIAL']
languages:
- C++
time: 2017-05-04 (10:16)
time: 2017-05-04T10:16:00Z
2 changes: 1 addition & 1 deletion confidential/3c7cc54/3c7cc54.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ fix:
fix-in: ['CONFIDENTIAL']
languages:
- C++
time: 2015-10-07 (16:10)
time: 2015-10-07T16:10:00Z
2 changes: 1 addition & 1 deletion confidential/7b11629/7b11629.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ fix:
fix-in: ['CONFIDENTIAL']
languages:
- C++
time: 2017-06-27 (16:45)
time: 2017-06-27T16:45:00Z
2 changes: 1 addition & 1 deletion confidential/86cb680/86cb680.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ fix:
fix-in: ['CONFIDENTIAL']
languages:
- C++
time: 2017-07-03 (11:27)
time: 2017-07-03T11:27:00Z
2 changes: 1 addition & 1 deletion confidential/96e2c6c/96e2c6c.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ fix:
fix-in: ['trajectory_generation.cpp', 'utils.h']
languages:
- C++
time: 2017-02-09 (16:43)
time: 2017-02-09T16:43:00Z
Loading