Skip to content

[WIP] Fix cob#376

Closed
hsd-dev wants to merge 22 commits intorobust-rosin:masterfrom
hsd-dev:fix-cob
Closed

[WIP] Fix cob#376
hsd-dev wants to merge 22 commits intorobust-rosin:masterfrom
hsd-dev:fix-cob

Conversation

@hsd-dev
Copy link
Contributor

@hsd-dev hsd-dev commented Oct 19, 2020

Currently added only fault and failure codes. This PR is behind #359

languages:
- CMake
time: 2014-11-21 (12:57)
time: 2014-11-21T12:57:00Z
Copy link
Member

@gavanderhoorn gavanderhoorn Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note again: unless the original time was already in UTC, this is not a valid conversion.

It's likely these times were reported in CET or CEST, which would make this +0200 (but this is just a guess).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not worked on that. As I mentioned in the comment, I have worked only on fault and failure codes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand your comment: are you saying you didn't change these time entries?

What makes them show up in the diff here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR build on #359? See also #359 (comment), where I commented on 0c46707.

Copy link
Contributor Author

@hsd-dev hsd-dev Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this PR is behind #359. I have not modified the time yet after your comment.

I have not worked on that.

Sorry about the confusion. I meant 'after your comment'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent we accidentally merge this, perhaps drop 0c46707 for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to avoid the confusion and separate the concerns, I will remove 0c46707, so #359 is only about the script and the schema.

This was referenced Oct 19, 2020
languages: C++

time: 2015-03-03 (2015-03-12 2:53 GMT+1)
time: 2015-03-03T2015-03-12:00Z 2:53 GMT+1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks borked

languages: C++

time: 2014-05-12 (21:11 GMT+1)
time: 2014-05-12T21:11:00Z GMT+1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timezone is borked

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the discussion above. After my initial awk command, I have dropped the commit 0c46707 in #359. Once it is merged, I will rebase this PR. Currently in this PR I have only worked on fault and failure codes.

languages: CMake

time: 2014-12-16 (10:01am GMT+1)
time: 2014-12-16T10:01am:00Z GMT+1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borked

@hsd-dev
Copy link
Contributor Author

hsd-dev commented Jan 13, 2021

closing for #391

@hsd-dev hsd-dev closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants