Add default github issue templates under ros2 org.#3
Merged
Conversation
fujitatomoya
commented
Nov 13, 2024
Contributor
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
I would like to get more feedback here as default issue templates under ros2 org. any comments are welcome! thanks in advance.
CC: @clalancette @kscottz
kscottz
approved these changes
Nov 13, 2024
Collaborator
kscottz
left a comment
kscottz
left a comment
There was a problem hiding this comment.
Hi Tomoya,
This is certainly better than what we presently have so I'll approve it. I've made a couple of suggestions comments. We may want to discuss further at the PMC meeting next week.
clalancette
requested changes
Nov 15, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Overall, I like the idea.
However, I do think we should strive to have a minimum of fields here. The more we have, the more confusing it is for people to report bugs (and a number of things will be filled in incorrectly anyway). I've left a couple of comments inline towards making this simpler.
This was referenced Nov 21, 2024
Contributor
Author
|
@clalancette can you review this? i think it is okay to deploy, and if any repositories have their own templates, this will not affect them. IMO, it is hard to complete the perfect format, so would like to get some feedback from time to time. |
This was referenced Nov 21, 2024
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Katherine Scott <katherineAScott@gmail.com>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
fujitatomoya/org-issue-template
branch
from
50b7578 to
3f671c1
Compare
Contributor
Author
|
@clalancette is there anything i can do on my side? |
Contributor
Author
|
according to the issue template status below, what i need to do is,
once all of those PRs are approved, we can merge all together. Issue Template Status
|
clalancette
approved these changes
Feb 4, 2025
mjcarroll
requested changes
Feb 4, 2025
Member
mjcarroll
left a comment
mjcarroll
left a comment
There was a problem hiding this comment.
Hold for ros2_documentation template.
Contributor
Author
|
This was referenced Mar 25, 2025
Contributor
Author
@mjcarroll ros2/ros2_documentation#5140 ros2 documentation template has been merged, so this is good to go. once you merge this, can you let me know? i will post the announcement on ROS discourse too.
i will remove deprecated templates as follow up one by one. |
mjcarroll
approved these changes
Mar 25, 2025
Member
|
@fujitatomoya Looks great! Thanks for getting this in! Feel free to post on discourse. |
This was referenced Mar 31, 2025
This was referenced Mar 31, 2025
Merged
Merged
Contributor
Author
minor maintenance for removing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes ros2/ros2#1572
if we take this default org scope github issue and feature templates and configuration, we can close the following PRs all together.