Add github templates for bug reports and features. Also links for important ROS related sites.#782
Add github templates for bug reports and features. Also links for important ROS related sites.#782peterborkuti wants to merge 11 commits intoros2:rollingfrom
Conversation
peterborkuti
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
|
👍 |
peterborkuti
force-pushed
the
github_templates
branch
from
b9044cc to
f6469d5
Compare
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
IMO this is good enhancement! thanks for the PR.
peterborkuti
force-pushed
the
github_templates
branch
2 times, most recently
from
d6ca727 to
47a15a4
Compare
peterborkuti
force-pushed
the
github_templates
branch
6 times, most recently
from
7514aa5 to
62a683c
Compare
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
peterborkuti
force-pushed
the
github_templates
branch
from
62a683c to
36b4221
Compare
audrow
left a comment
audrow
left a comment
There was a problem hiding this comment.
This is great!
I made a few small suggestions.
It's also probably best to remove the existing issue template correct?
Co-authored-by: Audrow Nash <audrow@intrinsic.ai> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Audrow Nash <audrow@intrinsic.ai> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Audrow Nash <audrow@intrinsic.ai> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
peterborkuti
left a comment
peterborkuti
left a comment
There was a problem hiding this comment.
Thank you for your suggestions.
|
@peterborkuti, should the existing template be removed in this PR? Also, make sure the DCO check passes. After these, we should be able to get this in. |
peterborkuti
force-pushed
the
github_templates
branch
from
16d8d3f to
c3162bc
Compare
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
peterborkuti
force-pushed
the
github_templates
branch
from
c3162bc to
f4f64d3
Compare
|
@audrow |
|
Hi, |
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
|
The current plan is to go with org template ros2/.github#3, so i will go ahead to close this for now. if the repository specific templates are required, of course we can do that for each repository templete. |
|
Dear @fujitatomoya |
|
My apology for this decision change after all these iteration, but this sometimes happens after discussion with developers. I really appreciate you for being so responsive to apply the changes, thanks for that. i did not mean to be rude. as you pointed out, i should have been much louder on this change with you to share the progress. (i missed you on ros2/.github#3, so added as co-author, sorry about that too.) besides, if this is still better for this repository specific templates, feel free to reopen. |
5 participants
Hi,
I checked #779 and I thought, I could help.
This is what you were thinking about?
You can try the configurations here:
https://github.com/peterborkuti/launch/issues
Here is how it looks like:
I was thinking about creating drop downs with OS and DDS versions.
Hope you like it
Péter