-
Notifications
You must be signed in to change notification settings - Fork 34
Add a pixi toml url to the build parameter arguments #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated-by: Claude Code Opus-4.5 (2025/11/01 release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM!
Thanks for setting this up this will make it much easier to roll Windows dependencies 🎉 .
We can monopolize test_ci_windows momentarily and deploy these changes there to validate that they work as expected.
|
This pull request has been mentioned on Open Robotics Discourse. There might be relevant details there: https://discourse.openrobotics.org/t/ros-pmc-minutes-for-january-20-2026/52015/1 |
|
It looks like the "original" behavior determined the URL dynamically by substituting the ROS distro. When we trigger a job for a distribution other than Rolling, there's currently a bunch of job parameters that we need to change. Would it be possible to make the default value for this parameter empty, which will produce the existing behavior? There are certainly other parameters that should behave like this but don't, and it would be great to set a better precedent moving forward. |
Description
Currently the location of the pixi.toml file is a bit hardcoded. See
ci/windows_docker_resources/Dockerfile
Line 53 in 15f43e0
This PR adds a CI_PIXI_TOML_URL parameter that will add an option to add an custom pixi.toml url (like in a gist). This allows us to test PRs like this one: ros2/ros2#1785 (this adds a version change to pixi.toml), and we would able to debug dependency issues without having to make a branch on the main ros2/CI repository for windows.
This is related to issue #832
Is this user-facing behavior change?
Yes, on ci.ros.org users can now see an new parameter called CI_PIXI_TOML_URL that they can fill in with another url as similar fasion as with CI_ROS2_REPOS_URL. But nothing should happen if they don't fill it in.
Did you use Generative AI?
Yes, only for one commit: 2ff6534
this was done with Claude Code (Opus 4.5)
Additional Information
I'll leave it in draft as I just want to double check things before merging (or have people look at it at least to see if I'm not breaking the whole CI!)