Add a pixi toml url to the build parameter arguments (ported from #839) #841
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knmcguire
requested review from
clalancette,
cottsay and
nuclearsandwich
as code owners
Collaborator
Author
|
The idea is that we will try to deploy this particular branch on one of the test_ci jobs just to try it out since there is no CI to this PR. So we can wait with merging this PR after we have looked and settled that |
Generated-by: Claude Code Opus-4.5 (2025/11/01 release)
cottsay
force-pushed
the
knmcguire/windows-ci-parameters
branch
from
55973ff to
3d20cf7
Compare
Member
|
@knmcguire, I rebased this to make it easier to deploy to the |
Member
|
Deployed here: https://ci.ros2.org/job/test_ci_windows/ |
Collaborator
Author
|
Thanks! And good we tested it out here because it indeed fails! I will look into it 😄 |
Collaborator
Author
|
Still testing things out in the test ci! the latest github outages delayed that a bit, so as soon as I confirm this working I'll convert it back to 'ready for review' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the description of #839
Ported to be a branch in ROS/ci so that we could more easily deploy it on a test ci job to test it out according to @claraberendsen