Runtime Interface Reflection: type_description_interfaces_utils#155
Closed
methylDragon wants to merge 5 commits intorollingfrom
Closed
Runtime Interface Reflection: type_description_interfaces_utils#155methylDragon wants to merge 5 commits intorollingfrom
methylDragon wants to merge 5 commits intorollingfrom
Conversation
31 tasks
9a608df to
3760e4d
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
457c9ba to
7ab657d
Compare
7ab657d to
5810619
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
338cc7c to
ffcdfa8
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
ffcdfa8 to
78d4f90
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
2 tasks
Author
|
Closing this in favor of ros2/rosidl#728 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the runtime interface reflection subscription feature of REP-2011: ros2/ros2#1374
Description
This PR adds a utilities library for manipulating and constructing the C structs generated by
type_description_interfaces, including:I also pre-generate the
type_description_interfacessources and headers to create a new package (type_description_interfaces_static) to remove a dependency cycle downstream. (That's why there are so many lines.)I haven't implemented tests yet, so some memory management issues/segfaults are expected. I'm working on it, but I am wary of spending too much time getting 100% coverage because we're trying to meet the deadline for feature freeze...I've implemented a bunch of tests and I'm fairly confident that most of the core functionalities work as expected now, so I'm going to mark the PR as ready to review.
Asan runs green too!
There are some less important tests waiting to be written (printing), and some tests that are already implicitly covered by other tests (but are not explicit yet.)
TODO
Open Questions
type_description_interfaces_utils_cinstead? 😬