Merged
Conversation
This was referenced Mar 16, 2023
9115cea to
74d35b0
Compare
4155c36 to
a1cc3d8
Compare
61a04cd to
27d6e78
Compare
27d6e78 to
3fc6394
Compare
wjwwood
requested changes
Apr 6, 2023
Member
wjwwood
left a comment
There was a problem hiding this comment.
Initial review with a few requested changes, but mostly non-blocking nitpicks.
We're still trying to nail down the double-free issues in some of the tests.
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/type_description_utils.h
Outdated
Show resolved
Hide resolved
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
f759287 to
a448392
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
a448392 to
b759f94
Compare
Contributor
Author
|
I'm not too sure why DCO is kicking up a fuss |
wjwwood
reviewed
Apr 7, 2023
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
wjwwood
approved these changes
Apr 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends (and is based on): #727
This PR is part of the runtime interface reflection subscription feature of REP-2011: ros2/ros2#1374
emersonknapp/type-descripton-runtimebranch it builds ontop of to help with reviewing. But when #727 gets merged, this should then retargetrollingDescription
This PR adds utilities for manipulating the
rosidl_runtime_c__type_descriptionstructs defined in #727It was migrated (and further modified from): ros2/rcl_interfaces#155
Functionalities:
Asan runs green too!
There are some less important tests waiting to be written (printing), and some tests that are already implicitly covered by other tests (but are not explicit yet.)
TODO
Open Questions